fix: Remove glob syntax from tracePropagationTargets example
#8312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lforst
approved these changes
Oct 23, 2023
krystofwoldrich
approved these changes
Oct 23, 2023
Sounds good to me, thanks! |
|
The fix also makes sense for Apple. If you provide a string it's string.contains. For regexes you have to pass in instances of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered by @lforst in #8267 (comment), we showed an incorrect example for
tracePropagationTargetsvalues in the "Usage->Distributed Tracing" page (example). TPT values can only be String.contains matches or regex matches but glob patterns in strings like"https://.*.otherservice.org/.*"are not supported.This PR removes the glob pattern and adds a regex example to show both types of TPT values.
(Adjusted the one for Astro in #8267)
Note: The same value is used in Flutter and iOS docs but I'm not yet sure if these SDKs support globs or not. Asked in Slack for clarification.