-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(inbound-filters): Add health check explanation #7649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inbound-filters): Add health check explanation #7649
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- **Common browser extension errors** | ||
- **Events coming from localhost** | ||
- **Known legacy browsers errors** | ||
- **Known web crawlers** | ||
- **By their error message** | ||
- **From specific release versions of your code** | ||
- **From certain IP addresses** | ||
- **Transactions coming from healthcheck and ping requests** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to not bold these since we're not referencing UI elements and it's weird to call attention to an entire list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see "Filter out hydration errors" in my UI and looks like this is missing from the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense and good catch. I will update the list
A node will be red if it is associated with errors. | ||
Click "View Full Trace" to display the [Trace View](/product/sentry-basics/tracing/trace-view). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a sudden change of topic. It's unclear to me what nodes and traces you're talking about here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was mistakenly added... I just removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after implementing the feedback from @vivianyentran 👍
Before:
After:
Related: getsentry/sentry#54539