Skip to content

feat(inbound-filters): Add health check explanation #7649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

priscilawebdev
Copy link
Member

Before:

image

After:

image

Related: getsentry/sentry#54539

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 8:13am

Comment on lines 19 to 26
- **Common browser extension errors**
- **Events coming from localhost**
- **Known legacy browsers errors**
- **Known web crawlers**
- **By their error message**
- **From specific release versions of your code**
- **From certain IP addresses**
- **Transactions coming from healthcheck and ping requests**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to not bold these since we're not referencing UI elements and it's weird to call attention to an entire list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see "Filter out hydration errors" in my UI and looks like this is missing from the list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense and good catch. I will update the list

Comment on lines 47 to 48
A node will be red if it is associated with errors.
Click "View Full Trace" to display the [Trace View](/product/sentry-basics/tracing/trace-view).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a sudden change of topic. It's unclear to me what nodes and traces you're talking about here.

Copy link
Member Author

@priscilawebdev priscilawebdev Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was mistakenly added... I just removed :)

Copy link
Contributor

@ale-cota ale-cota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after implementing the feedback from @vivianyentran 👍

@priscilawebdev priscilawebdev merged commit be76182 into master Aug 17, 2023
@priscilawebdev priscilawebdev deleted the priscila/feat/inbound-filters/add-health-check-explanation branch August 17, 2023 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants