Add source maps upload instructions for CRA #7628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vivianyentran
approved these changes
Aug 15, 2023
| ### 3. Inject Debug IDs Into Build Artifacts | ||
|
|
||
| Debug IDs are used to match the stack frame of an event with its corresponding minified source and source map file. | ||
| Visit [What are Artifact Bundles](/platforms/javascript/sourcemaps/troubleshooting_js/artifact-bundles/) if you want to learn more about Artifact Bundles and Debug IDs. |
There was a problem hiding this comment.
Suggested change
| Visit [What are Artifact Bundles](/platforms/javascript/sourcemaps/troubleshooting_js/artifact-bundles/) if you want to learn more about Artifact Bundles and Debug IDs. | |
| Visit [What are Artifact Bundles](/platforms/javascript/sourcemaps/troubleshooting_js/artifact-bundles/) if you want to learn more about artifact bundles and debug IDs. |
There was a problem hiding this comment.
"Artifact Bundles" and "Debug IDs" are terms we invented which is why we capitalize them. If we lowercase them here we need to do this over the entire docs.
| 2. Injected Debug IDs into the artifacts you've just generated | ||
| 3. Uploaded those artifacts to Sentry with our upload command | ||
|
|
||
| The last step is deploying a new version of your application using the generated artifacts you created in step one. |
There was a problem hiding this comment.
Suggested change
| The last step is deploying a new version of your application using the generated artifacts you created in step one. | |
| The last step is deploying a new version of your application using the generated artifacts you created. |
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
should we add this here generically or create something specific for react? i'm just thinking it might be good to get people looking at next or browser and missing
|
lgtm! just added it to the overview page under guides 
|
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
|
Thanks @vivianyentran for the review! |
adinauer
pushed a commit
that referenced
this pull request
Aug 18, 2023
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com> Co-authored-by: Steven Eubank <47563310+smeubank@users.noreply.github.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7106
Adds instructions on how to get source maps working with Create React App.