ref(platforms): Improve implementation of platformRegistry #7505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
evanpurkhiser
commented
Jul 25, 2023
| } | ||
| `; | ||
|
|
||
| export const formatCaseStyle = (style: string, value: string): string => { |
There was a problem hiding this comment.
Didn't make sense for this to be exported in usePlatforms.
evanpurkhiser
commented
Jul 25, 2023
| // community, | ||
| // } | ||
|
|
||
| export type Guide = { |
There was a problem hiding this comment.
Moved to a types file
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-platforms-improve-implementation-of-platformregistry
branch
2 times, most recently
from
c904066 to
b5271ee
Compare
evanpurkhiser
commented
Jul 25, 2023
| // platform might actually not be a platform, so lets handle that case gracefully | ||
| if (!(currentPlatform as Platform).guides) { | ||
|
|
||
| if (currentPlatform.type === 'guide') { |
There was a problem hiding this comment.
We're now able to discriminate on the type property to indicate if it's a platform or a platform guide. This is a lot cleaner.
evanpurkhiser
commented
Jul 25, 2023
There was a problem hiding this comment.
Everything is typed much better in here, making a bit more clear the distinction between a Platform and a PlatformGuide.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-platforms-improve-implementation-of-platformregistry
branch
from
b5271ee to
48d64b4
Compare
gggritso
approved these changes
Jul 25, 2023
| }; | ||
|
|
||
| export function GuideGrid({platform, className}: Props) { | ||
| const [currentPlatform] = usePlatform(platform); |
There was a problem hiding this comment.
🤔 a little confusing that usePlatform might return a guide, but I guess that's just the data model?
src/shared/platformRegistry.ts
Outdated
| } from '../types'; | ||
|
|
||
| /** | ||
| * Common default values that all platform configs will recieve (but may be |
There was a problem hiding this comment.
Suggested change
| * Common default values that all platform configs will recieve (but may be | |
| * Common default values that all platform configs will receive (but may be |
src/shared/platformRegistry.ts
Outdated
| this._keyMap = {}; | ||
| /** | ||
| * When the given config object has a fallbackPlatform, this will ensure the | ||
| * `propegatedConfig` keys are present with their values from the |
There was a problem hiding this comment.
Suggested change
| * `propegatedConfig` keys are present with their values from the | |
| * `propagatedConfig` keys are present with their values from the |
src/shared/platformRegistry.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Constructs the patlform registry mapping object. |
There was a problem hiding this comment.
Suggested change
| * Constructs the patlform registry mapping object. | |
| * Constructs the platform registry mapping object. |
dashed
approved these changes
Jul 25, 2023
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-platforms-improve-implementation-of-platformregistry
branch
from
e285f45 to
ed5afe3
Compare
shanamatthews
approved these changes
Jul 26, 2023
This change simplfies the PlatformRegistry
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-platforms-improve-implementation-of-platformregistry
branch
from
ed5afe3 to
35dc377
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-platforms-improve-implementation-of-platformregistry
branch
shanamatthews
pushed a commit
that referenced
this pull request
Jul 31, 2023
This change simplfies the PlatformRegistry
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the
PlatformRegistryin various ways. I will leave inline comments on the PR.