Skip to content

feat(crons): Add Node SDK cron monitoring docs #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2023

Conversation

AbhiPrasad
Copy link
Member

ref getsentry/sentry#43661

In version7.51.0 of the Node SDK we'll be releasing support for cron monitoring as implemented here: getsentry/sentry-javascript#8039

This PR adds documentation for it.

@AbhiPrasad AbhiPrasad requested review from gaprl, lizokm, a team, mydea and lforst and removed request for a team May 4, 2023 14:40
@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 1:07pm

@gaprl
Copy link
Member

gaprl commented May 4, 2023

Great job team!

@lizokm lizokm requested a review from shanamatthews May 4, 2023 18:29
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but I think you missed adding node to the platform section component in src/platforms/common/crons/troubleshooting-crons.mdx

Comment on lines +1 to +3
### How Do I Send an Attachment With a Check-in (Such as a Log Output)?

Attachments aren't supported by our Node SDK yet. For now, you can use the [check-in attachments API](/product/crons/getting-started/http/#check-in-attachment-optional).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content doesn't appear in the preview.

I think you missed adding <PlatformSection supported={["python", "php", "node"]}>

to src/platforms/common/crons/troubleshooting-crons.mdx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed with 8a30507

@AbhiPrasad AbhiPrasad force-pushed the abhi-node-crons-docs branch from d791e76 to 421fe56 Compare May 8, 2023 12:41
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) May 8, 2023 12:45
@AbhiPrasad AbhiPrasad merged commit e68267c into master May 8, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-node-crons-docs branch May 8, 2023 12:55
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants