-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(crons): Add Node SDK cron monitoring docs #6842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Great job team! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, but I think you missed adding node to the platform section component in src/platforms/common/crons/troubleshooting-crons.mdx
### How Do I Send an Attachment With a Check-in (Such as a Log Output)? | ||
|
||
Attachments aren't supported by our Node SDK yet. For now, you can use the [check-in attachments API](/product/crons/getting-started/http/#check-in-attachment-optional). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content doesn't appear in the preview.
I think you missed adding <PlatformSection supported={["python", "php", "node"]}>
to src/platforms/common/crons/troubleshooting-crons.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed with 8a30507
d791e76
to
421fe56
Compare
ref getsentry/sentry#43661
In version
7.51.0
of the Node SDK we'll be releasing support for cron monitoring as implemented here: getsentry/sentry-javascript#8039This PR adds documentation for it.