Skip to content

feat(perf-issues): Add Large Render Blocking Asset docs #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 28, 2023

Conversation

mjq-sentry
Copy link

@mjq-sentry mjq-sentry commented Feb 22, 2023

Todo:

  • Update span evidence to match docs (done)
  • Take resource.render_blocking_status into consideration to match docs (done)

@vercel
Copy link

vercel bot commented Feb 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 3:16PM (UTC)

@mjq-sentry mjq-sentry requested review from a team and lizokm February 22, 2023 16:06
@mjq-sentry mjq-sentry changed the title feat(perf-issues): Add Large Render Blocking Asset docs [DRAFT] feat(perf-issues): Add Large Render Blocking Asset docs Feb 22, 2023
@mjq-sentry mjq-sentry marked this pull request as ready for review February 22, 2023 21:45
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nothing blocking, just a bunch of suggestions making the explanations more specific!

mjq and others added 5 commits February 23, 2023 12:50
…-render-blocking-asset/index.mdx

Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx

Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx

Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx

Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx

Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
@mjq-sentry
Copy link
Author

@lizokm Could you please give these new issue type docs a look when you get a chance? Thanks!

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few small tweaks, but overall this LGTM

mjq and others added 7 commits February 28, 2023 09:47
…-render-blocking-asset/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@mjq-sentry
Copy link
Author

Thanks so much for the improvements @lizokm! Merged them all.

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants