-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(perf-issues): Add Large Render Blocking Asset docs #6338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nothing blocking, just a bunch of suggestions making the explanations more specific!
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
…-render-blocking-asset/index.mdx Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
…-render-blocking-asset/index.mdx Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
@lizokm Could you please give these new issue type docs a look when you get a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few small tweaks, but overall this LGTM
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/issues/issue-details/performance-issues/large-render-blocking-asset/index.mdx
Outdated
Show resolved
Hide resolved
…-render-blocking-asset/index.mdx Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx Co-authored-by: Liza Mock <liza.mock@sentry.io>
…-render-blocking-asset/index.mdx Co-authored-by: Liza Mock <liza.mock@sentry.io>
Thanks so much for the improvements @lizokm! Merged them all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Todo:
resource.render_blocking_status
into consideration to match docs (done)