feat(sdks): Add beforeSendTransaction to filtering page
#5838
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This adds the new `beforeSendTransaction` option to the docs, both on the options page and alongside `beforeSend` in many places in the text. Because you can't selectively turn certain phrases on and off for different platforms, I tried to indicate where I could that it's not universally supported. (Right now, I believe JS is in fact the only platform to support it, though I expect that to change in the near future.) It also does a tiny bit of wordsmithing of the text around the additions, courtesy of @lizokm and @imatwawana. Note that the one spot where updates haven't been done in this PR is the text of the Filtering page, as it's being worked on separately in #5804. Once the changes there are done, #5838 will add `beforeSendTransaction`.
|
@lobsterkatie What's the status here? |
It's currently waiting on #5804, which is actually done save dealing with language-specific snippets and hint properties (see #5811). I'm about to go on sabbatical, so cc @lizokm @imatwawana to help decide what the best path forward is. I think with not too much work, we could get the wordsmithing part of #5804 merged (assuming they seem like good changes), which would then unblock this PR, and chase the snippets/properties separately. Thoughts? |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
stephanie-anderson
deleted the
kmclb-add-beforeSendTransaction-to-filtering-page
branch
Note: Given the on-going work on the Filtering page, I'm splitting this off of the main PR adding
beforeSendTransactionto the docs. I'll update this as the filtering page work progresses, but leaving it in draft state for now. (If you're curious about what this PR will actually do in and of itself, look at the second commit below. Not expecting any reviews at this point, though.)This adds the new
beforeSendTransactionoption to the Filtering page.