Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remix SDK docs #5247

Merged
merged 7 commits into from
Jul 15, 2022
Merged

Add Remix SDK docs #5247

merged 7 commits into from
Jul 15, 2022

Conversation

onurtemizkan
Copy link
Collaborator

@vercel
Copy link

vercel bot commented Jul 4, 2022

@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@vladanpaunovic vladanpaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use these docs PR for us to discuss the overall developer experience of using the @sentry/remix SDK and ways to improve/simplify it.

Let's see how many of the ideas I have had here are actually doable. :)

@vercel
Copy link

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 2:15PM (UTC)

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording and formatting/style edits.

src/includes/capture-error/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/getting-started-config/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/getting-started-config/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/getting-started-config/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/getting-started-config/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/sourcemaps/overview/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/sourcemaps/overview/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/sourcemaps/overview/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/sourcemaps/upload/primer/javascript.remix.mdx Outdated Show resolved Hide resolved
src/includes/sourcemaps/upload/primer/javascript.remix.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@vladanpaunovic vladanpaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let's just wait for getsentry/sentry-javascript#5365 to be merged and then make sure to communicate only withSentry and remove all instances of withSentryRouteTracing

onurtemizkan and others added 3 commits July 8, 2022 13:51
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 15, 2022 13:24
@AbhiPrasad AbhiPrasad disabled auto-merge July 15, 2022 13:24
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 15, 2022 13:24
@AbhiPrasad AbhiPrasad merged commit eec1fb3 into getsentry:master Jul 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants