feat(tanstackstart-react): Add guide for setup without --import#16594
feat(tanstackstart-react): Add guide for setup without --import#16594nicohrubec wants to merge 4 commits intomasterfrom
--import#16594Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| } | ||
| ``` | ||
|
|
||
| #### Serverless (e.g. Vercel, Netlify) |
There was a problem hiding this comment.
m: We should list limitations with this approach. You can look at how we did that for other SDKs.
There was a problem hiding this comment.
right good call, added!
There was a problem hiding this comment.
@nicohrubec also now that I think about it, we should not call this "Serverless", have a look at https://docs.sentry.io/platforms/javascript/guides/nuxt/install/cli-import/#scenarios-where---import-does-not-work
Maybe we can rephrase this heading similarly.
There was a problem hiding this comment.
sure I changed the section names to reflect that the deciding difference is whether users can set --import or not
--import
andreiborza
left a comment
There was a problem hiding this comment.
LGTM, this makes it much clearer now!
For serverless environments where users can't set
--importflag on startup we need a slightly different setup, where users need to import theinstrument.server.mjsin the server entry file. So far we have no documentation for that, so I split the docs to set up server-side Sentry into two sections (one for normal node setup, one for serverless environments). The described setup should work starting from the next SDK release.