feat: Add better docs for setting the user #12224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 1.24kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
3 tasks
chargome
approved these changes
Dec 30, 2024
docs/platforms/javascript/common/enriching-events/identify-user/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/enriching-events/identify-user/index.mdx
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 30, 2024
docs/platforms/javascript/common/enriching-events/identify-user/index.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
approved these changes
Dec 30, 2024
Lms24
approved these changes
Jan 2, 2025
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 3, 2025
This was an express-specific, rather undocumented behavior, and also conflicted with our privacy-by-default stance. Starting in v9, you'll need to manually call `Sentry.setUser()` e.g. in a middleware to set the user on Sentry events. Docs for this are already pending: getsentry/sentry-docs#12224
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 7, 2025
This was an express-specific, rather undocumented behavior, and also conflicted with our privacy-by-default stance. Starting in v9, you'll need to manually call `Sentry.setUser()` e.g. in a middleware to set the user on Sentry events. Docs for this are already pending: getsentry/sentry-docs#12224
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
mydea
force-pushed
the
fn/set-user-docs
branch
from
94c4988 to
f9d2bda
Compare
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 7, 2025
This was an express-specific, rather undocumented behavior, and also conflicted with our privacy-by-default stance. Starting in v9, you'll need to manually call `Sentry.setUser()` e.g. in a middleware to set the user on Sentry events. Docs for this are already pending: getsentry/sentry-docs#12224
mydea
force-pushed
the
fn/set-user-docs
branch
from
f9d2bda to
ec38112
Compare
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 7, 2025
This was an express-specific, rather undocumented behavior, and also conflicted with our privacy-by-default stance. Starting in v9, you'll need to manually call `Sentry.setUser()` e.g. in a middleware to set the user on Sentry events. Docs for this are already pending: getsentry/sentry-docs#12224 Extracted this out of #14806
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the docs for setting the user in JS SDKs.