Skip to content

feat(flags): add browser JS integration docs for Launchdarkly #11827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Nov 14, 2024

Documents the integration added in getsentry/sentry-javascript#14207. Equivalent for server-side Python is #11675

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 10:25pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 10:25pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 10:25pm

Comment on lines +4 to +21
notSupported:
- javascript.aws-lambda
- javascript.azure-functions
- javascript.bun
- javascript.capacitor
- javascript.cloudflare
- javascript.connect
- javascript.cordova
- javascript.deno
- javascript.electron
- javascript.express
- javascript.fastify
- javascript.gcp-functions
- javascript.hapi
- javascript.koa
- javascript.nestjs
- javascript.nodejs
- javascript.wasm
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the non-frontend frameworks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature flags can be used on BE too. Does LD for example have a packge for browser and another for node?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LD has server-side node, yes, but the implementation + installation will look different, so we focus on client-side for now. See getsentry/sentry-javascript#14207 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tldr; the hook used to listen for evaluations doesn't exist for node. If it does, it works differently. This is also the reason we can't support specific frontend frameworks, only the generic launchdarkly-js-client-sdk

Copy link

codecov bot commented Nov 14, 2024

Bundle Report

Changes will increase total bundle size by 258 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 264 bytes (0.0%) ⬆️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

@aliu39 aliu39 requested a review from billyvg November 14, 2024 22:02
@aliu39 aliu39 merged commit 344a0c2 into master Nov 15, 2024
11 checks passed
@aliu39 aliu39 deleted the aliu/ld-js branch November 15, 2024 00:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants