-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(angular): Add documentation for Sentry's ErrorHandler
#11361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 231 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
lforst
approved these changes
Sep 16, 2024
lizokm
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding, this looks great!
docs/platforms/javascript/guides/angular/features/error-handler.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/angular/features/error-handler.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/angular/features/error-handler.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/angular/features/error-handler.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-config/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <liza.mock@sentry.io>
7fc5618
to
005ce9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on top of #11356
This PR adds a new "Angular Features" sub page for the Angular SDK's
ErrorHandler
. Previously, the config options and some edge cases around the handler were undocumented and users had to ask for clarifications in GitHub and Discord.The new page now explains
reportDialog
options in favour of User Feedback)ref getsentry/sentry-javascript#13636