fix(angular): Ensure sourcemaps links have correct text color #11312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Lms24
commented
Sep 10, 2024
Comment on lines
+39
to
+42
| Generating sourcemaps may expose them to the public, potentially causing your | ||
| source code to be leaked. You can prevent this by configuring your server to | ||
| deny access to `.js.map` files, or by deleting the sourcemaps before deploying | ||
| your application. |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
chargome
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that if you make a link bold, the text color changes, making the link no longer appear purple. Might be a one-off though because we rarely make lists like this afaict
EDIT: Looks like any bold link is no longer coloured purple. Should we fix this? I guess there's rarely a reason to make a link bold so maybe it's also just fine if we leave it as-is