Skip to content

feat(quickstart): Add examples for all quickstart platforms #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented May 29, 2019

Just for the quickstart page, adds a 'sending a verification event' section.

@evanpurkhiser evanpurkhiser requested a review from dcramer May 29, 2019 00:12
@evanpurkhiser evanpurkhiser force-pushed the featquickstart-add-examples-for-all-quickstart-platforms branch from e257ba9 to 861643c Compare May 29, 2019 00:14
@eurica
Copy link
Contributor

eurica commented May 29, 2019

@evanpurkhiser This is the change that tells new projects how to send an easy error?

I'd love to do more later, but this is an improvement. I say :shipit:

@evanpurkhiser
Copy link
Member Author

There are a few more, but yeah this does some. Not all platform docs work the same way. I have quite a few PRs right now that do changes, but you can see all the ones that DON'T tell you here #1034

evanpurkhiser and others added 10 commits May 29, 2019 16:51
…-verify/aspnetcore.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/browser.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/cordova.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/csharp.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/electron.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/node.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/php.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/python.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
…-verify/rust.md

Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evanpurkhiser evanpurkhiser merged commit a6042fd into master May 30, 2019
@evanpurkhiser evanpurkhiser deleted the featquickstart-add-examples-for-all-quickstart-platforms branch May 30, 2019 00:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants