Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented May 14, 2024

I have seen people confused about that migr8 does not change Next.js configuration for example.

@vercel
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 4:46pm

@codecov
Copy link

codecov bot commented May 14, 2024

Bundle Report

Changes will decrease total bundle size by 11 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.38MB 4 bytes ⬇️
sentry-docs-edge-server 458.69kB 3 bytes ⬇️
sentry-docs-client 6.16MB 4 bytes ⬇️

@lforst lforst changed the title Clarify that migr8 does not do everything Suggest to still read the js v8 changelog despite having @sentry/migr8 May 14, 2024
@lforst lforst requested review from Lms24 and mydea May 14, 2024 16:42
```

Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`! For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations).
Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`! For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations). Despite having `@sentry/migr8`, we still recommend reading the migration guide, since `@sentry/migr8` does not cover all of the changes needed to migrate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`! For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations). Despite having `@sentry/migr8`, we still recommend reading the migration guide, since `@sentry/migr8` does not cover all of the changes needed to migrate.
Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`!
For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations).
<Alert level="warning">
Despite having `@sentry/migr8`, we still recommend reading this migration guide, since `@sentry/migr8` does not cover all of the changes needed to migrate.
</Alert>

If there's only a few additional changes needed, it would be great if we could point those out. If not, can leave this as is.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@Lms24
Copy link
Member

Lms24 commented May 15, 2024

I'm gonna merge this just in case you don't have time @lforst

@Lms24 Lms24 merged commit 713f222 into master May 15, 2024
@Lms24 Lms24 deleted the lforst-be-clear-about-migr8 branch May 15, 2024 13:13
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants