Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 25, 2025

📜 Description

Part of moving away from method channels

💡 Motivation and Context

Closes #3204

💚 How did you test it?

Manual, integration tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (bfabaf2) to head (bd9f890).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3314      +/-   ##
==========================================
+ Coverage   88.13%   89.22%   +1.09%     
==========================================
  Files         295       99     -196     
  Lines       10120     3406    -6714     
==========================================
- Hits         8919     3039    -5880     
+ Misses       1201      367     -834     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review October 30, 2025 09:32
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question.

Base automatically changed from enh/ffi-jni-tags-set to main October 30, 2025 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 416.71 ms 435.39 ms 18.67 ms
Size 13.93 MiB 15.06 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4298701 524.40 ms 633.30 ms 108.90 ms
54acf91 487.24 ms 529.60 ms 42.36 ms
eca355d 485.50 ms 569.85 ms 84.35 ms
6bcdc99 440.23 ms 435.77 ms -4.46 ms
dbd526b 504.88 ms 569.02 ms 64.15 ms
cf443d2 464.64 ms 479.04 ms 14.40 ms
2cf9161 454.12 ms 512.67 ms 58.55 ms
4481076 484.08 ms 505.70 ms 21.61 ms
e2d675d 457.92 ms 529.17 ms 71.25 ms
7cfbbd6 499.69 ms 592.24 ms 92.55 ms

App size

Revision Plain With Sentry Diff
4298701 6.54 MiB 7.71 MiB 1.17 MiB
54acf91 6.54 MiB 7.70 MiB 1.17 MiB
eca355d 6.54 MiB 7.70 MiB 1.16 MiB
6bcdc99 13.93 MiB 15.00 MiB 1.06 MiB
dbd526b 6.54 MiB 7.69 MiB 1.15 MiB
cf443d2 13.93 MiB 15.00 MiB 1.06 MiB
2cf9161 6.54 MiB 7.70 MiB 1.16 MiB
4481076 6.54 MiB 7.69 MiB 1.15 MiB
e2d675d 6.54 MiB 7.69 MiB 1.15 MiB
7cfbbd6 6.54 MiB 7.70 MiB 1.17 MiB

Previous results on branch: enh/ffi-jni-extras-set

Startup times

Revision Plain With Sentry Diff
7ac21d9 387.67 ms 383.59 ms -4.08 ms
3b8d068 383.06 ms 386.82 ms 3.76 ms
19bd02d 429.82 ms 447.82 ms 17.99 ms
580e5c5 375.88 ms 379.17 ms 3.29 ms
4be3592 381.31 ms 372.36 ms -8.95 ms
674d8bb 369.83 ms 379.08 ms 9.26 ms
0155ce9 400.14 ms 435.90 ms 35.76 ms
2ad66c2 367.17 ms 369.11 ms 1.93 ms

App size

Revision Plain With Sentry Diff
7ac21d9 13.93 MiB 15.06 MiB 1.13 MiB
3b8d068 13.93 MiB 15.06 MiB 1.13 MiB
19bd02d 13.93 MiB 15.06 MiB 1.13 MiB
580e5c5 13.93 MiB 15.06 MiB 1.13 MiB
4be3592 13.93 MiB 15.06 MiB 1.13 MiB
674d8bb 13.93 MiB 15.06 MiB 1.13 MiB
0155ce9 13.93 MiB 15.06 MiB 1.13 MiB
2ad66c2 13.93 MiB 15.06 MiB 1.13 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1269.80 ms 1274.80 ms 5.00 ms
Size 5.53 MiB 6.01 MiB 487.96 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8541716 1270.18 ms 1271.80 ms 1.62 ms
9b99523 1256.06 ms 1270.33 ms 14.27 ms
e2d675d 1238.48 ms 1242.76 ms 4.28 ms
bfabaf2 1251.72 ms 1253.38 ms 1.67 ms
2cf9161 1248.33 ms 1266.55 ms 18.22 ms
819c1e7 1250.59 ms 1249.08 ms -1.51 ms
32914d8 1275.47 ms 1285.20 ms 9.73 ms
de377fd 1252.28 ms 1254.76 ms 2.48 ms
e04b24b 1230.22 ms 1233.90 ms 3.67 ms
5b9a0da 1249.69 ms 1250.71 ms 1.03 ms

App size

Revision Plain With Sentry Diff
8541716 5.53 MiB 6.00 MiB 479.96 KiB
9b99523 7.86 MiB 9.44 MiB 1.58 MiB
e2d675d 7.86 MiB 9.44 MiB 1.58 MiB
bfabaf2 5.53 MiB 6.01 MiB 487.95 KiB
2cf9161 7.86 MiB 9.44 MiB 1.58 MiB
819c1e7 5.53 MiB 6.00 MiB 479.96 KiB
32914d8 7.86 MiB 9.44 MiB 1.58 MiB
de377fd 20.71 MiB 22.43 MiB 1.73 MiB
e04b24b 5.53 MiB 6.00 MiB 480.00 KiB
5b9a0da 5.53 MiB 5.96 MiB 444.32 KiB

Previous results on branch: enh/ffi-jni-extras-set

Startup times

Revision Plain With Sentry Diff
2ad66c2 1264.88 ms 1265.20 ms 0.33 ms
7ac21d9 1253.00 ms 1254.51 ms 1.51 ms
580e5c5 1236.85 ms 1237.71 ms 0.86 ms
3b8d068 1244.55 ms 1246.49 ms 1.94 ms
19bd02d 1259.00 ms 1262.14 ms 3.14 ms
0155ce9 1249.80 ms 1252.81 ms 3.01 ms
674d8bb 1269.27 ms 1277.84 ms 8.57 ms
4be3592 1245.00 ms 1247.08 ms 2.08 ms

App size

Revision Plain With Sentry Diff
2ad66c2 5.53 MiB 6.01 MiB 487.96 KiB
7ac21d9 5.53 MiB 6.01 MiB 487.95 KiB
580e5c5 5.53 MiB 6.01 MiB 487.96 KiB
3b8d068 5.53 MiB 6.01 MiB 487.95 KiB
19bd02d 5.53 MiB 6.01 MiB 487.95 KiB
0155ce9 5.53 MiB 6.01 MiB 487.96 KiB
674d8bb 5.53 MiB 6.01 MiB 487.94 KiB
4be3592 5.53 MiB 6.01 MiB 487.97 KiB

@buenaflor buenaflor merged commit e1ab497 into main Oct 30, 2025
56 of 62 checks passed
@buenaflor buenaflor deleted the enh/ffi-jni-extras-set branch October 30, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FFI/JNI Refactor]: Scope sync e.g user/contexts/extras/tags/breadcrumbs

3 participants