Skip to content

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Sep 4, 2025

📜 Description

Fixes a recursion happening when calling openDatabase on a SentrySqfliteDatabaseFactory instance where no database factory has been passed

💡 Motivation and Context

Fixes #3229

💚 How did you test it?

Unit tests

Also ran the test without the fix which fails as expected

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.95%. Comparing base (5be269a) to head (a9d436d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3231      +/-   ##
==========================================
+ Coverage   87.93%   87.95%   +0.01%     
==========================================
  Files         290        7     -283     
  Lines        9982      465    -9517     
==========================================
- Hits         8778      409    -8369     
+ Misses       1204       56    -1148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review September 4, 2025 10:21
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

@buenaflor buenaflor merged commit 4acbd17 into main Sep 4, 2025
19 checks passed
@buenaflor buenaflor deleted the fix/sqflite-recursion branch September 4, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite recursion when _databaseFactory is null in SentrySqfliteDatabaseFactory (line 53)
2 participants