Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jul 10, 2025

from could install any cocoa version that is not the next major. we should use exact instead

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (0fb3800) to head (7291f63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
+ Coverage   88.00%   89.79%   +1.79%     
==========================================
  Files         287       96     -191     
  Lines        9534     3332    -6202     
==========================================
- Hits         8390     2992    -5398     
+ Misses       1144      340     -804     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor buenaflor changed the title ci: use Xcode 16.4 for SPM test fix: SPM should use exact instead of from when defining the sentry-cocoa package Jul 10, 2025
@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 471.62 ms 494.68 ms 23.06 ms
Size 6.54 MiB 7.69 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
93b7728 475.28 ms 489.13 ms 13.86 ms
ec78888 457.94 ms 519.96 ms 62.02 ms
c8596a6 474.00 ms 492.96 ms 18.96 ms
2d34233 470.54 ms 558.90 ms 88.36 ms
9b99523 456.91 ms 490.55 ms 33.64 ms
640ad0c 466.00 ms 552.67 ms 86.67 ms
73dca78 476.53 ms 522.21 ms 45.68 ms
b6c8720 457.41 ms 519.04 ms 61.63 ms
e2d675d 457.92 ms 529.17 ms 71.25 ms
827bf09 475.40 ms 547.14 ms 71.74 ms

App size

Revision Plain With Sentry Diff
93b7728 6.54 MiB 7.69 MiB 1.15 MiB
ec78888 6.54 MiB 7.69 MiB 1.15 MiB
c8596a6 6.54 MiB 7.53 MiB 1015.27 KiB
2d34233 6.54 MiB 7.55 MiB 1.01 MiB
9b99523 6.54 MiB 7.69 MiB 1.15 MiB
640ad0c 6.54 MiB 7.69 MiB 1.15 MiB
73dca78 6.54 MiB 7.69 MiB 1.15 MiB
b6c8720 6.54 MiB 7.69 MiB 1.15 MiB
e2d675d 6.54 MiB 7.69 MiB 1.15 MiB
827bf09 6.54 MiB 7.53 MiB 1015.27 KiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1262.39 ms 1279.04 ms 16.66 ms
Size 7.86 MiB 9.44 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0fb3800 1256.60 ms 1266.28 ms 9.68 ms
6ba4675 1223.12 ms 1238.17 ms 15.04 ms
9b99523 1256.06 ms 1270.33 ms 14.27 ms
e2d675d 1238.48 ms 1242.76 ms 4.28 ms
2d34233 1258.19 ms 1268.92 ms 10.73 ms
ec78888 1251.37 ms 1269.40 ms 18.04 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms
c8596a6 1234.11 ms 1241.19 ms 7.08 ms
640ad0c 1241.04 ms 1253.96 ms 12.92 ms

App size

Revision Plain With Sentry Diff
0fb3800 7.86 MiB 9.44 MiB 1.58 MiB
6ba4675 7.86 MiB 9.44 MiB 1.58 MiB
9b99523 7.86 MiB 9.44 MiB 1.58 MiB
e2d675d 7.86 MiB 9.44 MiB 1.58 MiB
2d34233 7.86 MiB 9.44 MiB 1.58 MiB
ec78888 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB
c8596a6 7.86 MiB 9.44 MiB 1.58 MiB
640ad0c 7.86 MiB 9.44 MiB 1.58 MiB

@buenaflor buenaflor marked this pull request as ready for review July 10, 2025 12:54
@buenaflor buenaflor enabled auto-merge (squash) July 10, 2025 13:18
@buenaflor buenaflor merged commit aeb02f2 into main Jul 10, 2025
66 checks passed
@buenaflor buenaflor deleted the ci/fix-spm branch July 10, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants