Skip to content

Conversation

@buenaflor
Copy link
Contributor

Update rules to keep all io.sentry classes instead of only io.sentry.android.replay

Tested the change locally

@buenaflor buenaflor requested a review from vaind July 3, 2025 19:35
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (2d34233) to head (152fd00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
+ Coverage   87.97%   89.85%   +1.87%     
==========================================
  Files         287       96     -191     
  Lines        9533     3331    -6202     
==========================================
- Hits         8387     2993    -5394     
+ Misses       1146      338     -808     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 456.54 ms 546.40 ms 89.86 ms
Size 6.54 MiB 7.69 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c8596a6 474.00 ms 492.96 ms 18.96 ms
6ba4675 499.80 ms 632.43 ms 132.63 ms
827bf09 475.40 ms 547.14 ms 71.74 ms
2d34233 470.54 ms 558.90 ms 88.36 ms

App size

Revision Plain With Sentry Diff
c8596a6 6.54 MiB 7.53 MiB 1015.27 KiB
6ba4675 6.54 MiB 7.53 MiB 1015.26 KiB
827bf09 6.54 MiB 7.53 MiB 1015.27 KiB
2d34233 6.54 MiB 7.55 MiB 1.01 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.80 ms 1256.44 ms 17.64 ms
Size 7.86 MiB 9.44 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
827bf09 1261.86 ms 1276.41 ms 14.55 ms
c8596a6 1234.11 ms 1241.19 ms 7.08 ms
2d34233 1258.19 ms 1268.92 ms 10.73 ms
6ba4675 1223.12 ms 1238.17 ms 15.04 ms

App size

Revision Plain With Sentry Diff
827bf09 7.86 MiB 9.44 MiB 1.58 MiB
c8596a6 7.86 MiB 9.44 MiB 1.58 MiB
2d34233 7.86 MiB 9.44 MiB 1.58 MiB
6ba4675 7.86 MiB 9.44 MiB 1.58 MiB

@buenaflor buenaflor merged commit 93b7728 into main Jul 4, 2025
133 of 138 checks passed
@buenaflor buenaflor deleted the fix/update-proguard-rules-keep-all-io-sentry-classes branch July 4, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants