-
-
Notifications
You must be signed in to change notification settings - Fork 267
deps upgrade Kotlin languageVersion to 1.8
#3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
===========================================
- Coverage 87.97% 63.09% -24.89%
===========================================
Files 287 4 -283
Lines 9533 168 -9365
===========================================
- Hits 8387 106 -8281
+ Misses 1146 62 -1084 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CHANGELOG.md
Outdated
options.feedback.showBranding = false; | ||
``` | ||
|
||
### Dependencies | ||
|
||
- Upgrade Kotlin languageVersion to `1.8` ([#3032](https://github.com/getsentry/sentry-dart/pull/3032)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mark this a s a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll mark it as potentially breaking. the number of people potentially affected should be really low
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'll try it out first myself in a sample app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out, still compiles even with older plugin versions fine
changelog sanity check. since @stefanosiano clarified it's fine to update it and won't affect users, I guess it shouldn't hurt to still call out to update the toolchain if its outdated? |
yep we should call it out clearly, it's still a breaking change in the sense that people might need to update toolchains not just locally, but also on CI etc. |
Updated the changelog |
@kahest wdyt of the changelog, updated it to be 'potentially breaking' |
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- deps upgrade Kotlin languageVersion to `1.8` ([#3032](https://github.com/getsentry/sentry-dart/pull/3032)) If none of the above apply, you can opt out of this check by adding |
📜 Description
Fixes error
which happens when bumping the kotlin-android plugin to
2.2.0
💡 Motivation and Context
Closes #3028
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps