-
-
Notifications
You must be signed in to change notification settings - Fork 255
[Structured Logs]: Expose Public API #2940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/logs
Are you sure you want to change the base?
Conversation
# Conflicts: # dart/lib/src/sentry_client.dart # dart/lib/src/sentry_options.dart
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/logs #2940 +/- ##
=============================================
- Coverage 87.72% 87.60% -0.13%
=============================================
Files 277 278 +1
Lines 9133 9162 +29
=============================================
+ Hits 8012 8026 +14
- Misses 1121 1136 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a closer look tomorrow
📜 Description
SentryLogger
toSdkLog
options.logger
tooptions.log
💡 Motivation and Context
Closes #2924
💚 How did you test it?
Unit tests, example app
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
@buenaflor I'm only seeing logs when they are sent through the web version (JS). I'm assuming the native SDKs are missing envelope header info, as they can't parse what they don't know.