Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 26, 2023

📜 Description

https://github.com/getsentry/sentry-dart/actions/runs/4807449597/jobs/8556234575?pr=1406

#skip-changelog

💡 Motivation and Context

fluttercommunity/plus_plugins@2cd002d#diff-c7f0423327ce8d62afcbea390b7a606f8a3c65e678eb09bb11eb55137ec34a7f

  • What went wrong:
    A problem occurred evaluating project ':package_info_plus'.

No signature of method: build_5pobc6g32m71evqvv19fi289r.android() is applicable for argument types: (build_5pobc6g32m71evqvv19fi289r$_run_closure2) values: [build_5pobc6g32m71evqvv19fi289r$_run_closure2@5fed17d5]

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto marked this pull request as draft April 26, 2023 11:41
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (01f095e) 90.24% compared to head (86e817e) 90.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         181      181           
  Lines        5792     5792           
=======================================
  Hits         5227     5227           
  Misses        565      565           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto marked this pull request as ready for review April 26, 2023 12:23
Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marandaneto marandaneto merged commit c4f1621 into main Apr 27, 2023
@marandaneto marandaneto deleted the fix/min-test branch April 27, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants