-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat(attributes): add search alias metadata #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,6 +99,63 @@ | |
| "type": "string" | ||
| } | ||
| }, | ||
| "search_aliases": { | ||
| "description": "Public search aliases and their mappings to Sentry span datasets", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "public_alias": { | ||
| "description": "The public name exposed in Sentry search", | ||
| "type": "string" | ||
| }, | ||
| "internal_name": { | ||
| "description": "The internal attribute name used by the EAP search resolver", | ||
| "type": "string" | ||
| }, | ||
|
Comment on lines
+113
to
+116
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this always duplicate the attribute's |
||
| "search_type": { | ||
| "description": "The type exposed by Sentry search, including unit-aware types", | ||
| "enum": [ | ||
| "string", | ||
| "boolean", | ||
| "integer", | ||
| "number", | ||
| "byte", | ||
| "currency", | ||
| "millisecond", | ||
| "percentage", | ||
| "second" | ||
| ] | ||
| }, | ||
| "secondary_alias": { | ||
| "description": "Whether the alias is accepted for queries but omitted from autocomplete suggestions", | ||
| "type": "boolean" | ||
| }, | ||
| "private": { | ||
| "description": "Whether the internal attribute should be hidden from public search results", | ||
| "type": "boolean" | ||
| }, | ||
|
Comment on lines
+135
to
+138
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this already covered by |
||
| "dataset_mappings": { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given the two other two comments re: |
||
| "description": "Exact query column mappings for Sentry's span datasets", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "minProperties": 1, | ||
| "properties": { | ||
| "spans": { | ||
| "description": "The column expression in the indexed spans dataset", | ||
| "type": "string" | ||
| }, | ||
|
Comment on lines
+145
to
+148
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This dataset has been removed. Only EAP exists now. |
||
| "eap": { | ||
| "description": "The column expression in the Events Analytics Platform dataset", | ||
| "type": "string" | ||
| } | ||
|
Comment on lines
+149
to
+152
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems better left to the Sentry backend to compute. (What's sent to EAP isn't a string either, so I don't think this is helpful here anyway). We do need a way to record when the search types and internal types of an attribute mismatch, though. I'd rather expose an (optional) |
||
| } | ||
| } | ||
| }, | ||
| "required": ["public_alias", "internal_name", "search_type", "dataset_mappings"] | ||
| } | ||
| }, | ||
| "additional_context": { | ||
| "description": "A list of freeform notes providing additional context about how this attribute behaves, common pitfalls, or query-time nuances", | ||
| "type": "array", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can likely make string the default, so not required.