Skip to content

chore(tests): Manually print failed test if xcbeautify fails to parse #7493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itaybre merged 1 commit into from
Feb 20, 2026
Merged

chore(tests): Manually print failed test if xcbeautify fails to parse #7493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/unit-test-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ jobs:
# Use a separate result bundle name to avoid conflicts with the regular test run.
# xcodebuild fails if a result bundle already exists at the target path.
- name: Run Flaky Tests
id: run_flaky_tests
# Only the Sentry Scheme has the Flaky TestPlan.
if: ${{ inputs.scheme == 'Sentry' }}
env:
Expand All @@ -142,6 +143,7 @@ jobs:
--result-bundle flaky-results.xcresult

- name: Run tests
id: run_tests
# We call a script with the platform so the destination
# passed to xcodebuild doesn't end up in the job name,
# because GitHub Actions don't provide an easy way of
Expand All @@ -164,6 +166,7 @@ jobs:
--result-bundle results.xcresult

- name: Publish Test Report
id: publish_test_report
uses: mikepenz/action-junit-report@74626db7353a25a20a72816467ebf035f674c5f8 # v6.2.0
if: always()
with:
Expand All @@ -172,6 +175,23 @@ jobs:
fail_on_parse_error: true
detailed_summary: true

# When a test crashes, xcbeautify may not report the failure in the junit.xml,
# so the test step fails but Publish Test Report finds no failures. In that case,
# extract failure info from the raw xcodebuild log.
- name: Analyze raw test output for crashes
if: ${{ always() && steps.publish_test_report.outcome == 'success' && (steps.run_tests.outcome == 'failure' || steps.run_flaky_tests.outcome == 'failure') }}
run: |
echo "::warning::Tests failed but no failures were found in the test report. This usually indicates a test crashed without proper reporting to xcbeautify."
echo ""
if [ -f raw-test-output.log ]; then
if grep -q "Failing tests:" raw-test-output.log; then
echo "=== Failing tests from raw output ==="
sed -n '/Failing tests:/,/^$/p' raw-test-output.log
fi
else
echo "raw-test-output.log not found."
fi

- name: Archiving DerivedData Logs
uses: actions/upload-artifact@v6
if: steps.build_tests.outcome == 'failure'
Expand Down
Loading