Skip to content

ref: Convert SentrySample to Swift#7405

Draft
itaybre wants to merge 2 commits intomainfrom
itay/swift-sentry-sample
Draft

ref: Convert SentrySample to Swift#7405
itaybre wants to merge 2 commits intomainfrom
itay/swift-sentry-sample

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Feb 6, 2026

📜 Description

Converts SentrySample to Swift, mostly done by claude

💡 Motivation and Context

Less ObjC 🙌

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Internal Changes 🔧

  • Convert SentrySample to Swift by itaybre in #7405
  • Check AppKit linkage macOS by itaybre in #7343

🤖 This preview updates automatically when you update the PR.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.304%. Comparing base (c431600) to head (38deaea).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7405       +/-   ##
=============================================
- Coverage   85.327%   85.304%   -0.024%     
=============================================
  Files          481       482        +1     
  Lines        28612     28600       -12     
  Branches     12440     12439        -1     
=============================================
- Hits         24414     24397       -17     
- Misses        4153      4159        +6     
+ Partials        45        44        -1     
Files with missing lines Coverage Δ
...urces/Sentry/Profiling/SentryContinuousProfiler.mm 89.726% <ø> (ø)
...es/Sentry/Profiling/SentryProfilerSampleCreation.m 100.000% <100.000%> (ø)
...ces/Sentry/Profiling/SentryProfilerSerialization.m 63.598% <ø> (ø)
Sources/Sentry/Profiling/SentryProfilerState.mm 99.295% <100.000%> (-0.055%) ⬇️
Sources/Sentry/SentryProfileTimeseries.m 72.972% <ø> (ø)
Sources/Swift/Profiling/SentrySample.swift 100.000% <100.000%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c431600...38deaea. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.77 ms 1242.62 ms 24.85 ms
Size 24.14 KiB 1.10 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86b8951 1211.20 ms 1247.92 ms 36.72 ms
7e93d85 1205.28 ms 1243.71 ms 38.44 ms
870ddae 1224.24 ms 1249.45 ms 25.21 ms
29b6704 1216.31 ms 1251.91 ms 35.60 ms
9a0a3cd 1220.85 ms 1243.69 ms 22.83 ms
2e5230b 1207.41 ms 1240.41 ms 33.00 ms
a7d7fb6 1209.53 ms 1235.91 ms 26.38 ms
29f846e 1210.51 ms 1238.66 ms 28.15 ms
50e7b3e 1221.54 ms 1250.81 ms 29.27 ms
c431600 1221.94 ms 1259.82 ms 37.88 ms

App size

Revision Plain With Sentry Diff
86b8951 24.14 KiB 1.08 MiB 1.06 MiB
7e93d85 24.14 KiB 1.06 MiB 1.04 MiB
870ddae 24.14 KiB 1.10 MiB 1.08 MiB
29b6704 24.14 KiB 1.06 MiB 1.04 MiB
9a0a3cd 24.14 KiB 1.08 MiB 1.06 MiB
2e5230b 24.14 KiB 1.04 MiB 1.02 MiB
a7d7fb6 24.14 KiB 1.06 MiB 1.04 MiB
29f846e 24.14 KiB 1.07 MiB 1.04 MiB
50e7b3e 24.14 KiB 1.04 MiB 1.02 MiB
c431600 24.14 KiB 1.10 MiB 1.08 MiB

Previous results on branch: itay/swift-sentry-sample

Startup times

Revision Plain With Sentry Diff
edb00a9 1225.69 ms 1259.46 ms 33.77 ms

App size

Revision Plain With Sentry Diff
edb00a9 24.14 KiB 1.10 MiB 1.08 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant