fix: Record cached dyld images async #7269
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
❌ 1 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
itaybre
reviewed
Jan 23, 2026
| add_dyld_image(mh); | ||
| } | ||
|
|
||
| void dyld_tracker_start(void) { |
Contributor
There was a problem hiding this comment.
Maybe this should have sentry's prefix
Member
|
@noahsmartin, I didn't check the code yet, as this is still a draft. Please be aware that they also need the loaded binary image in the UIViewControllerSwizzling, as pointed out here #4618 (comment). If the proposal respects this, then excellent. |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 015d376 | 1187.58 ms | 1211.28 ms | 23.70 ms |
| 680923d | 1211.40 ms | 1241.00 ms | 29.60 ms |
| edcda5a | 1217.52 ms | 1248.72 ms | 31.20 ms |
| 0d145c3 | 1224.04 ms | 1255.34 ms | 31.30 ms |
| 37ebda0 | 1201.62 ms | 1223.76 ms | 22.13 ms |
| d427374 | 1226.81 ms | 1257.74 ms | 30.94 ms |
| 29b6704 | 1216.31 ms | 1251.91 ms | 35.60 ms |
| d4dd2bd | 1218.59 ms | 1255.21 ms | 36.61 ms |
| a7d7fb6 | 1209.53 ms | 1235.91 ms | 26.38 ms |
| fd24b7c | 1222.39 ms | 1259.67 ms | 37.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 015d376 | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| 680923d | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| edcda5a | 24.14 KiB | 1.08 MiB | 1.06 MiB |
| 0d145c3 | 24.14 KiB | 1.07 MiB | 1.05 MiB |
| 37ebda0 | 24.14 KiB | 1.10 MiB | 1.07 MiB |
| d427374 | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| 29b6704 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| d4dd2bd | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| a7d7fb6 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| fd24b7c | 24.14 KiB | 1.07 MiB | 1.04 MiB |
Previous results on branch: imageCacheAsync
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 629dd8e | 1225.23 ms | 1252.12 ms | 26.89 ms |
| f02c17c | 1212.57 ms | 1246.06 ms | 33.49 ms |
| 823a3af | 1206.16 ms | 1222.51 ms | 16.35 ms |
| 272a47a | 1233.83 ms | 1249.33 ms | 15.50 ms |
| 496a3e1 | 1221.53 ms | 1251.12 ms | 29.59 ms |
| fb2a4b2 | 1217.60 ms | 1244.74 ms | 27.15 ms |
| 7847014 | 1222.58 ms | 1241.55 ms | 18.97 ms |
| 45a6e74 | 1217.39 ms | 1254.95 ms | 37.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 629dd8e | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| f02c17c | 24.14 KiB | 1.10 MiB | 1.07 MiB |
| 823a3af | 24.14 KiB | 1.08 MiB | 1.06 MiB |
| 272a47a | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 496a3e1 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| fb2a4b2 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 7847014 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 45a6e74 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
noahsmartin
force-pushed
the
imageCacheAsync
branch
6 times, most recently
from
52e7b6d to
51622cf
Compare
noahsmartin
force-pushed
the
imageCacheAsync
branch
2 times, most recently
from
f9ef564 to
2ca37c1
Compare
noahsmartin
force-pushed
the
imageCacheAsync
branch
from
2ca37c1 to
0503c4b
Compare
noahsmartin
force-pushed
the
imageCacheAsync
branch
from
12d75cf to
6fa7332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for how I think we should solve #4618
It fixes an existing race condition and moves the image handler to a background thread. Synchronization is now done safely with atomics so the crash handler can read from the added images without risk of race conditions (which existed before).
#skip-changelog