feat: Use full flamegraph for metrickit app hangs#7185
Draft
noahsmartin wants to merge 1 commit intomainfrom
Draft
feat: Use full flamegraph for metrickit app hangs#7185noahsmartin wants to merge 1 commit intomainfrom
noahsmartin wants to merge 1 commit intomainfrom
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Metrics
Other
Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Use full flamegraph for metrickit app hangs ([#7185](https://github.com/getsentry/sentry-cocoa/pull/7185))If none of the above apply, you can opt out of this check by adding |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Comment on lines
+111
to
+120
| // First look for the crashing thread, but for events that were not a crash (like a hang) take the first thread | ||
| // since those events only report one thread | ||
| let exceptionThread = threads.first { $0.crashed?.boolValue == true } ?? threads.first | ||
| event.debugMeta = debugMeta | ||
| event.threads = threads | ||
|
|
||
| if let exceptionThread, let exception = event.exceptions?[0] { | ||
| exception.stacktrace = exceptionThread.stacktrace | ||
| exception.threadId = exceptionThread.threadId | ||
| } |
Member
There was a problem hiding this comment.
h: I know this is a draft, but this question is crucial to ask. Do you have any clue how grouping is going to work for these types of exceptions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of only providing the most commonly sampled stacktrace, we can capture the full call stack tree for metric kit hangs and show them as a flamegraph. The frontend implementation of this is here: getsentry/sentry#106412