Skip to content

Conversation

@philprime
Copy link
Member

Description

This PR fixes the file-filters.yml configuration by adding the missing SentryTestUtilsTests/** directory pattern to ensure changes to test utility tests trigger the unit test CI workflow.

Additionally, it introduces a new Cursor rule (.cursor/rules/file-filters.mdc) to prevent similar issues in the future by providing comprehensive guidelines for maintaining the file-filters.yml configuration.

Changes

  • ✅ Added SentryTestUtilsTests/** to run_unit_tests_for_prs filter
  • ✅ Created .cursor/rules/file-filters.mdc with detailed guidelines for file-filters maintenance
  • ✅ Includes verification checklist for PRs affecting project structure
  • ✅ Provides bash commands for detecting missing filter patterns

Related

Fixes an issue from PR #6639 where the new SentryTestUtilsTests/ directory was not included in the file-filters configuration.

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.163%. Comparing base (a4e1541) to head (7319124).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6652       +/-   ##
=============================================
+ Coverage   84.960%   85.163%   +0.202%     
=============================================
  Files          452       452               
  Lines        27668     27668               
  Branches     12115     12117        +2     
=============================================
+ Hits         23507     23563       +56     
+ Misses        4113      4059       -54     
+ Partials        48        46        -2     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e1541...7319124. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.09 ms 1257.60 ms 34.51 ms
Size 23.75 KiB 1023.81 KiB 1000.07 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7f4bf81 1241.73 ms 1270.66 ms 28.93 ms
afaa522 1234.71 ms 1256.19 ms 21.48 ms
0b6776b 1230.18 ms 1262.06 ms 31.88 ms
c6c1cb7 1235.71 ms 1263.80 ms 28.08 ms
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
d72784d 1214.31 ms 1241.35 ms 27.04 ms
37238de 1236.00 ms 1267.80 ms 31.80 ms
dad68ad 1229.15 ms 1261.98 ms 32.83 ms
5ae9ff1 1222.31 ms 1250.96 ms 28.65 ms
b115f82 1212.96 ms 1251.92 ms 38.96 ms

App size

Revision Plain With Sentry Diff
7f4bf81 23.75 KiB 919.70 KiB 895.95 KiB
afaa522 23.74 KiB 996.91 KiB 973.17 KiB
0b6776b 23.75 KiB 968.23 KiB 944.49 KiB
c6c1cb7 23.75 KiB 928.15 KiB 904.40 KiB
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
d72784d 23.75 KiB 988.01 KiB 964.27 KiB
37238de 23.75 KiB 963.18 KiB 939.43 KiB
dad68ad 23.75 KiB 912.37 KiB 888.63 KiB
5ae9ff1 23.74 KiB 971.82 KiB 948.08 KiB
b115f82 23.75 KiB 989.04 KiB 965.30 KiB

Previous results on branch: philprime/fix-file-filter

Startup times

Revision Plain With Sentry Diff
2199928 1190.77 ms 1227.24 ms 36.47 ms
c612239 1222.40 ms 1249.56 ms 27.17 ms

App size

Revision Plain With Sentry Diff
2199928 23.75 KiB 1.00 MiB 1005.08 KiB
c612239 23.75 KiB 1.01 MiB 1006.48 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit 12b7c04 into main Nov 4, 2025
178 of 183 checks passed
@philprime philprime deleted the philprime/fix-file-filter branch November 4, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants