Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 3, 2025

I'm refactoring SentryOptions to be in Swift and figured we could take the opportunity to cleanup this implementation.

Closes #6645

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.02 ms 1221.47 ms 6.45 ms
Size 23.75 KiB 1023.89 KiB 1000.14 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
995b436 1217.54 ms 1254.26 ms 36.72 ms
f37e3fe 1230.24 ms 1254.51 ms 24.27 ms
0ac4c65 1236.85 ms 1267.84 ms 30.98 ms
339539a 1219.58 ms 1254.63 ms 35.05 ms
ebc3a34 1236.24 ms 1261.02 ms 24.78 ms
781f560 1232.83 ms 1263.56 ms 30.73 ms
e98d6f5 1228.51 ms 1258.85 ms 30.34 ms
b709887 1193.52 ms 1216.74 ms 23.22 ms
37183fe 1212.33 ms 1238.92 ms 26.59 ms
3279d4e 1215.76 ms 1256.45 ms 40.69 ms

App size

Revision Plain With Sentry Diff
995b436 23.75 KiB 1.02 MiB 1016.76 KiB
f37e3fe 23.75 KiB 919.70 KiB 895.95 KiB
0ac4c65 23.75 KiB 968.24 KiB 944.50 KiB
339539a 23.75 KiB 968.24 KiB 944.50 KiB
ebc3a34 23.75 KiB 919.91 KiB 896.16 KiB
781f560 23.75 KiB 1.02 MiB 1016.46 KiB
e98d6f5 23.75 KiB 933.03 KiB 909.28 KiB
b709887 23.75 KiB 1.01 MiB 1016.14 KiB
37183fe 23.75 KiB 913.63 KiB 889.87 KiB
3279d4e 23.75 KiB 938.32 KiB 914.57 KiB

Previous results on branch: simplifyOptions

Startup times

Revision Plain With Sentry Diff
895c47d 1223.31 ms 1249.46 ms 26.15 ms

App size

Revision Plain With Sentry Diff
895c47d 23.75 KiB 1023.89 KiB 1000.14 KiB

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@17a26bf). Learn more about missing BASE report.
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6644   +/-   ##
========================================
  Coverage        ?   85.141%           
========================================
  Files           ?       452           
  Lines           ?     27655           
  Branches        ?     12115           
========================================
  Hits            ?     23546           
  Misses          ?      4063           
  Partials        ?        46           
Files with missing lines Coverage Δ
Sources/Sentry/SentryOptions.m 96.153% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a26bf...064c86f. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin merged commit 2b0eac0 into main Nov 4, 2025
193 of 205 checks passed
@noahsmartin noahsmartin deleted the simplifyOptions branch November 4, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Cleanup SentryOptions implementation

4 participants