Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 29, 2025

Decided not to do this in V9, I missed this one spot in #6574

#skip-changelog

Closes #6595

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.468%. Comparing base (5ff1b04) to head (c5c991b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6594       +/-   ##
=============================================
+ Coverage   85.443%   85.468%   +0.025%     
=============================================
  Files          451       451               
  Lines        27424     27424               
  Branches     11933     11931        -2     
=============================================
+ Hits         23432     23439        +7     
+ Misses        3948      3939        -9     
- Partials        44        46        +2     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff1b04...c5c991b. Read the comment docs.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.45 ms 1259.89 ms 32.44 ms
Size 23.75 KiB 1.01 MiB 1016.25 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7c7ac56 1225.90 ms 1250.22 ms 24.33 ms
134fbdf 1219.71 ms 1240.35 ms 20.64 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms
2ca8f2e 1207.08 ms 1235.58 ms 28.49 ms
75b23cd 1227.10 ms 1253.61 ms 26.51 ms
6ee4973 1228.42 ms 1252.26 ms 23.84 ms
25f4532 1203.28 ms 1240.71 ms 37.44 ms
d8ceea3 1234.15 ms 1263.92 ms 29.77 ms
be8375a 1212.65 ms 1239.72 ms 27.08 ms
b9c733a 1195.49 ms 1220.23 ms 24.74 ms

App size

Revision Plain With Sentry Diff
7c7ac56 23.75 KiB 902.49 KiB 878.74 KiB
134fbdf 23.75 KiB 875.25 KiB 851.50 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB
2ca8f2e 23.74 KiB 996.96 KiB 973.21 KiB
75b23cd 23.75 KiB 933.66 KiB 909.92 KiB
6ee4973 23.75 KiB 896.53 KiB 872.79 KiB
25f4532 23.75 KiB 969.27 KiB 945.52 KiB
d8ceea3 23.75 KiB 980.81 KiB 957.07 KiB
be8375a 23.75 KiB 933.03 KiB 909.28 KiB
b9c733a 23.74 KiB 1021.49 KiB 997.74 KiB

@noahsmartin noahsmartin enabled auto-merge (squash) October 29, 2025 19:31
@noahsmartin noahsmartin merged commit 837f5e4 into main Oct 29, 2025
231 of 241 checks passed
@noahsmartin noahsmartin deleted the removeExtraV9Check branch October 29, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove extra V9 check

3 participants