Skip to content

Conversation

@noahsmartin
Copy link
Contributor

Not meant to be merged, just to start discussion about #6560

This also has the benefit of unifying the debug and non-debug codepaths to reduce the chances that a bug affects one environment but not the other

#skip-changelog

@noahsmartin noahsmartin force-pushed the removeSymbolication branch 3 times, most recently from b87555b to 38f322d Compare October 28, 2025 12:25
@codecov
Copy link

codecov bot commented Oct 28, 2025

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
3954 12 3942 28
View the top 3 failed test(s) by shortest run time
SentryCrashReportConverterTests::testNXPage
Stack Traces | 0s run time
.../Tests/SentryTests/SentryCrashReportConverterTests.m:272 - ((exception.stacktrace.frames.lastObject.symbolAddress) equal to (@"<redacted>")) failed: ("0x0000000000000000") is not equal to ("<redacted>")
SentryInterfacesTests::testFrame
Stack Traces | 0s run time
.../Tests/SentryTests/SentryInterfacesTests.m:56 - (([frame2 serialize]) equal to (serialized2)) failed: ("{
SentryTests.SentryANRTrackingIntegrationTests::testV2Detected_PauseCalled_ANRStopped_DoesCaptureEvent
Stack Traces | 0s run time
.../Integrations/ANR/SentryANRTrackingIntegrationTests.swift:453 - XCTAssertTrue failed - Not enough threads with frames
SentryTests.SentryANRTrackingIntegrationTests::testV2_ANRStopped_DoesCaptureEvent
Stack Traces | 0s run time
.../Integrations/ANR/SentryANRTrackingIntegrationTests.swift:395 - XCTAssertTrue failed - Not enough threads with frames
SentryTests.SentryDefaultThreadInspectorTests::testStackTrackForCurrentThreadAsyncUnsafe
Stack Traces | 0s run time
.../SentryTests/SentryCrash/SentryDefaultThreadInspectorTests.swift:209 - XCTAssertNotEqual failed: ("Optional("0x0000000000000000")") is equal to ("Optional("0x0000000000000000")")
SentryTests.SentryStacktraceBuilderTests::testConcurrentStacktraces
Stack Traces | 0s run time
.../SentryTests/SentryCrash/SentryStacktraceBuilderTests.swift:96 - XCTAssertGreaterThanOrEqual failed: ("0") is less than ("3") - The Stacktrace must include the async callers.
SentryTests.SentryStacktraceBuilderTests::testConcurrentStacktraces_noStitching
Stack Traces | 0s run time
.../SentryTests/SentryCrash/SentryStacktraceBuilderTests.swift:121 - XCTAssertGreaterThanOrEqual failed: ("0") is less than ("1") - The Stacktrace must have only one function.
iOS_Swift_UITests.LaunchUITests::testNavigationTransaction
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:21 - Failed to tap "testNavigationTransactionButton" Button: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testShowTableView
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - XCTAssertTrue failed - TableView not loaded.
iOS_Swift_UITests.LaunchUITests::testSplitView
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:55 - Failed to tap "showSplitViewButton" Button: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testUiClickTransaction
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/BaseUITest.swift:57 - Failed to launch <XCUIApplicationImpl: 0x600000d216e0 io.sentry.sample.iOS-Swift at .../Products/TestCI-iphonesimulator/iOS-Swift.app> via Xcode: Timed out while launching application via Xcode.
iOS_Swift_UITests.LaunchUITests::testUseAfterFreeAfterUIImageNamedEmptyString
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/BaseUITest.swift:57 - Failed to launch <XCUIApplicationImpl: 0x600000d216e0 io.sentry.sample.iOS-Swift at .../Products/TestCI-iphonesimulator/iOS-Swift.app> via Xcode: Timed out while launching application via Xcode.
View the full list of 1 ❄️ flaky test(s)
SentryTests.SentryStacktraceBuilderTests::testFramesOrder

Flake rate in main: 14.29% (Passed 36 times, Failed 6 times)

Stack Traces | 0s run time
.../SentryTests/SentryCrash/SentryStacktraceBuilderTests.swift:67 - XCTUnwrap failed: expected non-nil value of type "String"

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.91 ms 1251.59 ms 37.68 ms
Size 23.75 KiB 1021.67 KiB 997.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d66f082 1227.08 ms 1247.04 ms 19.96 ms
09471ff 1239.98 ms 1256.65 ms 16.67 ms
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
1bf432b 1200.22 ms 1226.90 ms 26.67 ms
b6f8eb3 1217.94 ms 1246.57 ms 28.63 ms
2ec2700 1238.28 ms 1258.82 ms 20.53 ms
52603c5 1226.94 ms 1257.66 ms 30.72 ms
409a607 1229.57 ms 1251.45 ms 21.88 ms
7d88965 1228.86 ms 1248.53 ms 19.67 ms
2be5991 1228.55 ms 1264.65 ms 36.10 ms

App size

Revision Plain With Sentry Diff
d66f082 23.75 KiB 928.85 KiB 905.10 KiB
09471ff 23.75 KiB 990.16 KiB 966.41 KiB
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
1bf432b 23.75 KiB 926.64 KiB 902.90 KiB
b6f8eb3 23.75 KiB 988.70 KiB 964.95 KiB
2ec2700 23.75 KiB 980.80 KiB 957.05 KiB
52603c5 23.75 KiB 969.78 KiB 946.03 KiB
409a607 23.74 KiB 874.08 KiB 850.33 KiB
7d88965 23.75 KiB 994.72 KiB 970.98 KiB
2be5991 23.75 KiB 994.73 KiB 970.98 KiB

Previous results on branch: removeSymbolication

Startup times

Revision Plain With Sentry Diff
b97c496 1228.33 ms 1259.09 ms 30.77 ms

App size

Revision Plain With Sentry Diff
b97c496 23.75 KiB 1.00 MiB 1001.63 KiB

@noahsmartin noahsmartin force-pushed the removeSymbolication branch 3 times, most recently from a2887a7 to 1392a12 Compare November 4, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants