chore: Convert SentryFramesTracker to Swift#6447
Merged
Conversation
itaybre
commented
Oct 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
=============================================
+ Coverage 86.706% 86.943% +0.236%
=============================================
Files 449 449
Lines 37636 37728 +92
Branches 17449 17460 +11
=============================================
+ Hits 32633 32802 +169
+ Misses 4958 4882 -76
+ Partials 45 44 -1
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e446901 | 1233.32 ms | 1252.32 ms | 19.00 ms |
| 7d88965 | 1228.86 ms | 1248.53 ms | 19.67 ms |
| 354b020 | 1223.88 ms | 1236.82 ms | 12.94 ms |
| b5a7583 | 1238.22 ms | 1263.94 ms | 25.71 ms |
| efa740d | 1220.71 ms | 1246.20 ms | 25.50 ms |
| 3cdbc22 | 1231.63 ms | 1251.06 ms | 19.43 ms |
| ef2c9b3 | 1222.12 ms | 1253.96 ms | 31.84 ms |
| d7461dc | 1233.69 ms | 1255.29 ms | 21.60 ms |
| 162cd7f | 1230.59 ms | 1256.76 ms | 26.16 ms |
| 3067c23 | 1230.48 ms | 1257.90 ms | 27.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e446901 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 7d88965 | 23.75 KiB | 994.72 KiB | 970.98 KiB |
| 354b020 | 23.75 KiB | 878.19 KiB | 854.44 KiB |
| b5a7583 | 23.75 KiB | 913.44 KiB | 889.68 KiB |
| efa740d | 23.75 KiB | 919.69 KiB | 895.95 KiB |
| 3cdbc22 | 23.75 KiB | 928.14 KiB | 904.40 KiB |
| ef2c9b3 | 23.75 KiB | 933.03 KiB | 909.29 KiB |
| d7461dc | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| 162cd7f | 23.75 KiB | 908.39 KiB | 884.64 KiB |
| 3067c23 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
noahsmartin
reviewed
Oct 17, 2025
Sources/Swift/Core/Integrations/FramesTracking/SentryFramesTracker.swift
Show resolved
Hide resolved
noahsmartin
reviewed
Oct 17, 2025
Sources/Swift/Core/Integrations/FramesTracking/SentryFramesTracker.swift
Show resolved
Hide resolved
noahsmartin
approved these changes
Oct 17, 2025
…coa-710-convert-sentryframestracker
Sources/Swift/Core/Integrations/FramesTracking/SentryFramesTracker.swift
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts SentryFramesTracker to Swift as part of our Swift Conversion