Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Jun 25, 2025

Release 8.53.0 job used a cache instead of building from scratch: https://github.com/getsentry/sentry-cocoa/actions/runs/15873193408/job/44760111068
The cache key did not include the version

Fixes: #5492

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.90 ms 1240.17 ms 21.27 ms
Size 23.75 KiB 858.68 KiB 834.93 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
f92cfa9 1217.94 ms 1240.06 ms 22.12 ms
63ac649 1192.10 ms 1216.78 ms 24.68 ms
d637379 1226.43 ms 1250.77 ms 24.34 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
35c962f 1207.61 ms 1235.90 ms 28.29 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms

App size

Revision Plain With Sentry Diff
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.63 KiB
63ac649 23.75 KiB 855.38 KiB 831.63 KiB
d637379 23.75 KiB 855.38 KiB 831.63 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
35c962f 23.75 KiB 854.77 KiB 831.02 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB

@itaybre itaybre mentioned this pull request Jun 25, 2025
@itaybre itaybre merged commit db9572a into main Jun 25, 2025
73 of 74 checks passed
@itaybre itaybre deleted the itaybre/fix_release_version branch June 25, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 8.53.0 seems broken

4 participants