-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(replay): SR Breadcrumbs include level name as a string #4141
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4141 +/- ##
=============================================
+ Coverage 91.362% 91.385% +0.022%
=============================================
Files 609 605 -4
Lines 48396 48313 -83
Branches 17420 17400 -20
=============================================
- Hits 44216 44151 -65
+ Misses 4088 4069 -19
- Partials 92 93 +1
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4259afd | 1234.04 ms | 1256.76 ms | 22.72 ms |
7b5ebd9 | 1195.55 ms | 1214.49 ms | 18.94 ms |
ac614f1 | 1252.86 ms | 1260.30 ms | 7.44 ms |
eb32a30 | 1242.57 ms | 1246.77 ms | 4.20 ms |
7f14650 | 1249.73 ms | 1269.88 ms | 20.14 ms |
20742ca | 1225.69 ms | 1243.71 ms | 18.01 ms |
01a28a9 | 1245.43 ms | 1255.98 ms | 10.55 ms |
861d361 | 1227.90 ms | 1231.45 ms | 3.55 ms |
5e78d2b | 1245.24 ms | 1270.28 ms | 25.04 ms |
8919322 | 1262.67 ms | 1269.90 ms | 7.22 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4259afd | 20.76 KiB | 419.70 KiB | 398.94 KiB |
7b5ebd9 | 21.58 KiB | 424.30 KiB | 402.71 KiB |
ac614f1 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
eb32a30 | 21.58 KiB | 424.34 KiB | 402.76 KiB |
7f14650 | 22.84 KiB | 402.63 KiB | 379.79 KiB |
20742ca | 21.58 KiB | 417.87 KiB | 396.28 KiB |
01a28a9 | 22.85 KiB | 405.39 KiB | 382.55 KiB |
861d361 | 20.76 KiB | 435.65 KiB | 414.89 KiB |
5e78d2b | 22.85 KiB | 411.17 KiB | 388.32 KiB |
8919322 | 22.84 KiB | 403.18 KiB | 380.34 KiB |
Previous results on branch: kw/fix-replay-breadcrumbs-level
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
19d22ca | 1220.51 ms | 1228.61 ms | 8.10 ms |
01dac4d | 1215.50 ms | 1229.16 ms | 13.66 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
19d22ca | 21.58 KiB | 677.95 KiB | 656.37 KiB |
01dac4d | 21.58 KiB | 677.96 KiB | 656.37 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep the current public API unchanged
Hm looks like requires code owner approval. Andrew is off the due to 4th July so either I force merge or we wait until monday |
📜 Description
This PR fixes SR Breadcrumb Level serialization. The level is now included as a string, which is used in the UI. Android and Browser work the same.
💡 Motivation and Context
Before the levels were send as numbers.
💚 How did you test it?
unit test, sample app
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.