-
-
Notifications
You must be signed in to change notification settings - Fork 352
feat: Include the screen names in the session replay #4126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ntry-cocoa into feat/SR-screen-name
Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
…entry/sentry-cocoa into chore/conver-session-replay
…entry/sentry-cocoa into chore/conver-session-replay
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
60dd0f5 | 1265.16 ms | 1275.04 ms | 9.88 ms |
0f30019 | 1239.22 ms | 1240.04 ms | 0.82 ms |
c151c14 | 1223.18 ms | 1246.56 ms | 23.38 ms |
49819af | 1263.92 ms | 1275.66 ms | 11.74 ms |
77c9c47 | 1236.98 ms | 1250.43 ms | 13.45 ms |
de033da | 1216.91 ms | 1222.84 ms | 5.92 ms |
a6f8b18 | 1236.96 ms | 1240.14 ms | 3.18 ms |
98cca71 | 1227.43 ms | 1239.22 ms | 11.79 ms |
cf97209 | 1234.06 ms | 1251.49 ms | 17.43 ms |
3bc6371 | 1205.00 ms | 1222.14 ms | 17.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
0f30019 | 22.84 KiB | 405.39 KiB | 382.54 KiB |
c151c14 | 21.58 KiB | 678.19 KiB | 656.61 KiB |
49819af | 20.76 KiB | 427.31 KiB | 406.55 KiB |
77c9c47 | 21.58 KiB | 641.28 KiB | 619.70 KiB |
de033da | 21.58 KiB | 418.15 KiB | 396.57 KiB |
a6f8b18 | 20.76 KiB | 431.87 KiB | 411.11 KiB |
98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
cf97209 | 21.58 KiB | 632.16 KiB | 610.58 KiB |
3bc6371 | 21.58 KiB | 418.69 KiB | 397.11 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4126 +/- ##
=============================================
+ Coverage 91.357% 91.362% +0.005%
=============================================
Files 604 606 +2
Lines 48179 48348 +169
Branches 17355 17453 +98
=============================================
+ Hits 44015 44172 +157
- Misses 4071 4083 +12
Partials 93 93
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
The screen names look good from RN point of view, RN already saves the screen name on the scope and cocoa doesn't write into that scope property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to move the various refactors out to a separate PR so this diff and associated changelog entry are scoped just to the addition of the screen name. I'm looking at things like renaming resizeImage
, the new struct VideoFrames
, changing the signature of createVideoWith
and SentryPixelBuffer.append
and createAndCapture
, changing the initial value of videoSegmentStart
, the + 1
s on those duration values.
Tests/SentryTests/Integrations/SessionReplay/SentrySessionReplayTests.swift
Outdated
Show resolved
Hide resolved
Tests/SentryTests/Integrations/SessionReplay/SentrySessionReplayTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
…ntry-cocoa into feat/SR-screen-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just checked the logic for screens, that part lgtm!
📜 Description
Include the screen names in the session replay
💚 How did you test it?
Unit test, samples
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.