Skip to content

feat: Include the screen names in the session replay #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Jul 10, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Include the screen names in the session replay

💚 How did you test it?

Unit test, samples

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.71 ms 1243.96 ms 18.24 ms
Size 21.58 KiB 684.01 KiB 662.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
60dd0f5 1265.16 ms 1275.04 ms 9.88 ms
0f30019 1239.22 ms 1240.04 ms 0.82 ms
c151c14 1223.18 ms 1246.56 ms 23.38 ms
49819af 1263.92 ms 1275.66 ms 11.74 ms
77c9c47 1236.98 ms 1250.43 ms 13.45 ms
de033da 1216.91 ms 1222.84 ms 5.92 ms
a6f8b18 1236.96 ms 1240.14 ms 3.18 ms
98cca71 1227.43 ms 1239.22 ms 11.79 ms
cf97209 1234.06 ms 1251.49 ms 17.43 ms
3bc6371 1205.00 ms 1222.14 ms 17.14 ms

App size

Revision Plain With Sentry Diff
60dd0f5 20.76 KiB 393.37 KiB 372.61 KiB
0f30019 22.84 KiB 405.39 KiB 382.54 KiB
c151c14 21.58 KiB 678.19 KiB 656.61 KiB
49819af 20.76 KiB 427.31 KiB 406.55 KiB
77c9c47 21.58 KiB 641.28 KiB 619.70 KiB
de033da 21.58 KiB 418.15 KiB 396.57 KiB
a6f8b18 20.76 KiB 431.87 KiB 411.11 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
cf97209 21.58 KiB 632.16 KiB 610.58 KiB
3bc6371 21.58 KiB 418.69 KiB 397.11 KiB

Previous results on branch: feat/SR-screen-name

Startup times

Revision Plain With Sentry Diff
5bead23 1206.14 ms 1223.49 ms 17.35 ms
fe6c70b 1211.74 ms 1237.02 ms 25.28 ms

App size

Revision Plain With Sentry Diff
5bead23 21.58 KiB 676.54 KiB 654.96 KiB
fe6c70b 21.58 KiB 671.88 KiB 650.30 KiB

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 95.96774% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.362%. Comparing base (d26797f) to head (faedb2e).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4126       +/-   ##
=============================================
+ Coverage   91.357%   91.362%   +0.005%     
=============================================
  Files          604       606        +2     
  Lines        48179     48348      +169     
  Branches     17355     17453       +98     
=============================================
+ Hits         44015     44172      +157     
- Misses        4071      4083       +12     
  Partials        93        93               
Files Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m 81.889% <100.000%> (+0.438%) ⬆️
...Integrations/SessionReplay/SentryPixelBuffer.swift 93.103% <100.000%> (+1.103%) ⬆️
...rations/SessionReplay/SentryReplayVideoMaker.swift 100.000% <100.000%> (ø)
...tegrations/SessionReplay/SentrySessionReplay.swift 91.304% <100.000%> (+0.054%) ⬆️
...t/Integrations/SessionReplay/SentryVideoInfo.swift 100.000% <100.000%> (ø)
...ions/SessionReplay/SentryOnDemandReplayTests.swift 97.560% <100.000%> (+0.300%) ⬆️
...onReplay/SentrySessionReplayIntegrationTests.swift 98.165% <100.000%> (+0.292%) ⬆️
...egrations/SessionReplay/SentryOnDemandReplay.swift 89.908% <96.666%> (-1.545%) ⬇️
...tegrations/SessionReplay/SentryReplayOptions.swift 92.592% <33.333%> (-7.408%) ⬇️
...tions/SessionReplay/SentrySessionReplayTests.swift 97.515% <94.594%> (-1.096%) ⬇️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26797f...faedb2e. Read the comment docs.

@brustolin brustolin marked this pull request as ready for review July 8, 2024 08:03
@brustolin brustolin requested review from romtsn and vaind July 8, 2024 08:04
@krystofwoldrich
Copy link
Member

The screen names look good from RN point of view, RN already saves the screen name on the scope and cocoa doesn't write into that scope property.

Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move the various refactors out to a separate PR so this diff and associated changelog entry are scoped just to the addition of the screen name. I'm looking at things like renaming resizeImage, the new struct VideoFrames, changing the signature of createVideoWith and SentryPixelBuffer.append and createAndCapture, changing the initial value of videoSegmentStart, the + 1 s on those duration values.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked the logic for screens, that part lgtm!

@brustolin brustolin merged commit 152437a into main Jul 10, 2024
66 checks passed
@brustolin brustolin deleted the feat/SR-screen-name branch July 10, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants