-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix: Crash in CppException Monitor #2639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only call previous terminate_handler if it's not NULL to avoid crashing. Fixes GH-1533
brustolin
approved these changes
Jan 20, 2023
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
feba2be | 1246.67 ms | 1254.64 ms | 7.97 ms |
302ee8b | 1194.02 ms | 1223.34 ms | 29.32 ms |
dc0db9e | 1246.06 ms | 1260.46 ms | 14.40 ms |
b2f82fa | 1236.94 ms | 1262.86 ms | 25.92 ms |
5cabf7e | 1247.12 ms | 1249.61 ms | 2.49 ms |
dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
7fb7afb | 1227.73 ms | 1243.16 ms | 15.43 ms |
b2f82fa | 1237.78 ms | 1256.02 ms | 18.24 ms |
3f1be0f | 1208.12 ms | 1225.72 ms | 17.60 ms |
56ec5d0 | 1194.39 ms | 1236.94 ms | 42.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
feba2be | 20.76 KiB | 414.45 KiB | 393.69 KiB |
302ee8b | 20.76 KiB | 419.62 KiB | 398.87 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
5cabf7e | 20.76 KiB | 419.67 KiB | 398.91 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
3f1be0f | 20.76 KiB | 414.44 KiB | 393.69 KiB |
56ec5d0 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
armcknight
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for including the link to the docs explaining the situation 👍🏻
Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp
Outdated
Show resolved
Hide resolved
…xception.cpp Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
philipphofmann
added a commit
that referenced
this pull request
Jan 23, 2023
Only call the previous terminate_handler if it's not NULL to avoid crashing. Fixes GH-1533 Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Only call the previous terminate_handler if it's not NULL to avoid crashing.
💡 Motivation and Context
Fixes #1533
💚 How did you test it?
Unit test.
📝 Checklist
🔮 Next steps