-
-
Notifications
You must be signed in to change notification settings - Fork 380
Description
Note
The pull request "chore(tests): Manually print failed test if xcbeautify fails to parse" was created by @itaybre but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
📜 Description
Adds a fallback step that detects when xcbeautify silently misses failed tests and prints them directly from the raw log, ensuring failures are always visible in CI output:
=== Failing tests from raw output ===
Failing tests:
SentrySDKInternalTests.testLogger_TransactionWithBindToScope_LogsInsideDispatchQueueMainAsync_simulatesCOCOA1119()
💡 Motivation and Context
When a test process crashes, xcodebuild may not emit the structured output that xcbeautify needs to detect and report failures. In those cases, xcbeautify continues with no failed tests reported (even though CI correctly fails with exit code 65) making it very hard to identify what went wrong without digging into raw logs manually.
This was observed in this CI run.
The fallback works by checking whether xcbeautify reported any failures, and if not, parsing the raw log directly to surface them.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
- I added tests to verify the changes.
- No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - I updated the docs if needed.
- I updated the wizard if needed.
- Review from the native team if needed.
- No breaking change or entry added to the changelog.
- No breaking change for hybrid SDKs or communicated to hybrid SDKs.