fix: lower log level for missing base ref detection (EME-369) #2813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningcode
force-pushed
the
fix/eme-369-improve-logging-in-cli
branch
from
491d9ac to
2bddbe0
Compare
runningcode
changed the title
runningcode
force-pushed
the
fix/eme-369-improve-logging-in-cli
branch
2 times, most recently
from
6d5dc18 to
a1a4ced
Compare
Changes the logging level from warn to info when failing to detect base branch reference in build uploads. This reduces noise in build logs for common scenarios including detached HEAD states in PRs and main/master branch builds where base ref detection failures are expected. Also removes --log-level=error from all build upload tests and updates test expectations to include the experimental warning that is now visible. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
runningcode
force-pushed
the
fix/eme-369-improve-logging-in-cli
branch
from
a1a4ced to
a0961a1
Compare
runningcode
requested review from
a team and
szokeasaurusrex
as code owners
szokeasaurusrex
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lowers the logging level from
warntoinfowhen failing to detect base branch reference in build uploads.Why
The warning message confuses users as it appears even in cases where we don't expect there to be a base reference (detached HEAD states, main/master builds, etc.). Changing to info level keeps the message available for debugging while hiding it by default.
Changes
warn!toinfo!in base ref detection error handling--log-level=errorfrom build upload tests to ensure info messages work correctly🤖 Generated with Claude Code
Note
Lower base-ref detection logging to info and update build upload trycmd tests to remove log-level flag and assert experimental warning output.
warn!toinfo!when failing to detect base branch reference insrc/commands/build/upload.rs.trycmdcases (tests/integration/_cases/build/*) to remove--log-level=errorand expect the experimental warning line in output.Written by Cursor Bugbot for commit a0961a1. This will update automatically on new commits. Configure here.