fix: Validate SENTRY_RELEASE
environment variable
#2807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same validation to
SENTRY_RELEASE
that we also apply to the--release
argument.Fixes #2444
Fixes CLI-7
Note
Validate SENTRY_RELEASE with the same rules as --release and refactor release validation/parsing for clap.
src/config.rs
):SENTRY_RELEASE
viaargs::validate_release
; ignore with warning if invalid; require release if missing.src/utils/args.rs
):validate_release
returninganyhow::Result<()>
and addparse_release
for clap.parse_release
for--release
and--version
value parsers.Written by Cursor Bugbot for commit 383ec69. This will update automatically on new commits. Configure here.