feat: automatically fetch base SHA in GitHub Actions PR workflows #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automatic base SHA detection for the build upload command when running in GitHub Actions pull request workflows. This eliminates the need to manually specify --base-sha in most cases. Changes: - Add extract_pr_base_sha_from_event() helper function - Add find_base_sha() function following the same pattern as find_head() - Update build upload command to use automatic base SHA detection - Add comprehensive tests for the new functionality Resolves EME-349 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
runningcode
force-pushed
the
no/nelsonosacky/eme-349-fetch-base-sha-automatically-in-sentry-cli-for-github
branch
from
e6ebe8a to
96aace1
Compare
runningcode
requested review from
a team and
szokeasaurusrex
as code owners
szokeasaurusrex
approved these changes
Sep 25, 2025
runningcode
deleted the
no/nelsonosacky/eme-349-fetch-base-sha-automatically-in-sentry-cli-for-github
branch
Closed
4 tasks
runningcode
added a commit
that referenced
this pull request
Sep 29, 2025
…2805) ## Summary - Add `get_github_head_ref()` function to automatically detect head branch from GitHub Actions environment variables - Integrate with upload command fallback chain to resolve detached HEAD scenarios - Use `GITHUB_HEAD_REF` for automatic head-ref detection in PR workflows See context reference: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts ## Context Resolves EME-367 - Auto-fetch correct head-ref value in detached HEAD state using GitHub Actions env variables. Follows the same pattern as recent work on base SHA auto-fetching (#2799). 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds get_github_head_ref() (reads GITHUB_HEAD_REF in pull_request) and makes build upload prefer it before git head ref to handle detached HEAD. > > - **Build Upload**: > - Update `src/commands/build/upload.rs` head-ref resolution to first use `get_github_head_ref()`; fall back to `git_repo_head_ref`. > - **VCS Utils**: > - Add `get_github_head_ref()` to read `GITHUB_HEAD_REF` when `GITHUB_EVENT_NAME` is `pull_request` with debug logging. > - Export and import updated in `utils::vcs` and upload command. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 332fe76. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically fetch base SHA for the build upload command when running in GitHub Actions pull request workflows. This eliminates the need to manually specify
--base-shain most cases.How it works
Priority order:
--base-shaargument)GITHUB_EVENT_PATHpayload (/pull_request/base/sha) when running in GitHub Actions PR workflowsfind_base_sha())Resolves: EME-349
🤖 Generated with Claude Code