Skip to content

feat(preprod): make sure at least one app bundle is present for upload #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 24, 2025
Merged

feat(preprod): make sure at least one app bundle is present for upload #2795

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
067013a
check for Info.plist inside app
trevor-e Sep 23, 2025
9a1aa5a
lint
trevor-e Sep 23, 2025
711543c
glob for all .app
trevor-e Sep 23, 2025
1bde751
feat(preprod): make sure at least one app bundle is present for upload
trevor-e Sep 23, 2025
cc2cd1c
Merge branch 'master' into telkins/empty-products
trevor-e Sep 24, 2025
654be79
lint
trevor-e Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/utils/build/validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ where
&path.join("Products/**/*.app").to_string_lossy(),
MatchOptions::new(),
)?;
for app_path in paths.flatten().filter(|path| path.is_dir()) {

let app_paths: Vec<_> = paths.flatten().filter(|path| path.is_dir()).collect();
if app_paths.is_empty() {
anyhow::bail!("Invalid XCArchive: No .app bundles found in the Products/ directory");
}

for app_path in app_paths {
if !app_path.join("Info.plist").exists() {
anyhow::bail!(
"Invalid XCArchive: Missing required Info.plist file in .app bundle: {}",
Expand Down