feat: restore GitHub Actions base branch detection #2792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningcode
requested review from
szokeasaurusrex and
a team
as code owners
szokeasaurusrex
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts commit c0beb47 to restore the GitHub Actions base branch detection functionality that was previously implemented in #2776.
Background
The original GHA base branch detection was reverted in #2789 due to CI failures on master. However, those test failures were actually resolved separately in #2791 by adding
--log-level=errorto suppress warning messages in the integration tests.Changes
This PR restores:
get_github_base_ref()function insrc/utils/vcs.rsthat detects base branch fromGITHUB_BASE_REFenvironment variableget_github_base_ref()functionThe test failures that caused the original revert have been resolved by the test fixes in #2791, so this functionality can now be safely restored.
🤖 Generated with Claude Code