ci(rust): Run CI against toolchain update bot PRs #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/rust-toolchain-update-ci-workflow
branch
from
99aacaa to
2ff1d15
Compare
lcian
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
I think it doesn't show up under the PR as the workflow is not triggered by the PR itself, rather by an API call, so GH cannot detect it.
You probably would still need to approve/commit to the PR to trigger the workflows, also considering that some of them are required, so that's good as it will prevent an accidental merge of broken stuff.
szokeasaurusrex
deleted the
szokeasaurusrex/rust-toolchain-update-ci-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRs from the Rust toolchain update bot don't trigger the
pull_request-triggered workflows. This is a GitHub feature, not a bug. This change adds aworkflow_dispatchtrigger to our CI action, and has the Rust toolchain update bot automatically trigger the action after opening the PR.I tested this change with #2781. Although the workflow run does not show on that PR, we can see that, in fact, the CI did run against the commit. My guess is maybe it has to do with the fact that the #2781 is against #2780, rather than the
masterbranch.