feat: Normalize VCS provider names to match backend

.craft.yml

@@ -1,5 +1,6 @@
 minVersion: 0.23.1
 changelogPolicy: auto
+postReleaseCommand: bash scripts/post-release.sh
 targets:
   - name: gcs
     bucket: sentry-sdk-assets

.github/workflows/ci.yml

@@ -28,6 +28,8 @@ jobs:
   test_node:
     name: Test Node
     uses: ./.github/workflows/test_node.yml
+    with:
+      triggered-by-release: ${{ github.event_name == 'push' && startsWith(github.ref_name, 'release/') }}
 
   test_swift:
     name: Test Swift

.github/workflows/test_node.yml

@@ -2,6 +2,11 @@ name: Test Node
 
 on:
   workflow_call:
+    inputs:
+      triggered-by-release:
+        type: boolean
+        description: Whether the workflow was triggered by a release
+        default: false
     outputs:
       matrix-result:
         description: 'Matrix job result'
@@ -19,10 +24,16 @@ jobs:
         with:
           node-version-file: package.json
 
-      # We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet.
-      # We have to use npm here because yarn fails on the non-existing existing optionalDependency version:
-      # https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326
-      - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm ci
+      - name: Install dependencies via npm ci
+        if: ${{ !inputs.triggered-by-release }}
+        run: npm ci
+
+      # For pushes to the release branch, we need to install the dependencies via `npm install`
+      # because the `package-lock.json` is not updated with the new versions of the optional
+      # dependencies yet. We also must skip the fallback download via --ignore-scripts.
+      - name: Install dependencies via npm install (for pushes to release branch)
+        if: ${{ inputs.triggered-by-release }}
+        run: npm install --omit=optional --ignore-scripts
 
       - run: npm run check:types
 
@@ -43,10 +54,16 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      # We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet.
-      # We have to use npm here because yarn fails on the non-existing existing optionalDependency version:
-      # https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326
-      - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm ci
+      - name: Install dependencies via npm ci
+        if: ${{ !inputs.triggered-by-release }}
+        run: npm ci
+
+      # For pushes to the release branch, we need to install the dependencies via `npm install`
+      # because the `package-lock.json` is not updated with the new versions of the optional
+      # dependencies yet. We also must skip the fallback download via --ignore-scripts.
+      - name: Install dependencies via npm install (for pushes to release branch)
+        if: ${{ inputs.triggered-by-release }}
+        run: npm install --omit=optional --ignore-scripts
 
       # older node versions need an older nft
       - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install @vercel/nft@0.22.1

CHANGELOG.md

@@ -2,6 +2,17 @@
 
 "You know what they say. Fool me once, strike one, but fool me twice... strike three." — Michael Scott
 
+## 2.54.0
+
+### Various fixes & improvements
+
+- Fix: symlinks in normalized upload (#2744) by @noahsmartin
+- feat(vcs): Prefer upstream remote over origin for base repo name (#2737) by @runningcode
+- feat(build): Add auto-detection of base_repo_name from git remote (#2735) by @runningcode
+- feat(build): Add auto-detection of PR number from GitHub Actions (#2722) by @runningcode
+- feat(build): Auto-detect base_ref from git merge-base (#2720) by @runningcode
+- feat(logs): support log streaming (#2666) by @vgrozdanic
+
 ## 2.53.0
 
 ### Various fixes & improvements
@@ -22,7 +33,7 @@ Please note, the `build` commands are still experimental, and are therefore subj
 
 ## 2.53.0-alpha
 
-This release reintroduces the `build` (previously named `mobile-app`) commands. 
+This release reintroduces the `build` (previously named `mobile-app`) commands.
 
 ### Various fixes & improvements
 

Cargo.toml

@@ -2,7 +2,7 @@
 authors = ["Armin Ronacher <armin.ronacher@active-4.com>"]
 build = "build.rs"
 name = "sentry-cli"
-version = "2.53.0"
+version = "2.54.0"
 edition = "2021"
 rust-version = "1.86"
 

apple-catalog-parsing/native/swift/AssetCatalogParser/Sources/AssetCatalogParser/AssetCatalogReader.swift

@@ -84,7 +84,9 @@ enum AssetUtil {
                 key.perform(Selector(("keyList"))),
                 to: UnsafeMutableRawPointer.self
             )
-            let rendition = createRendition(from: structuredThemeStore, keyList)
+            guard let rendition = createRendition(from: structuredThemeStore, keyList) else {
+                continue
+            }
 
             let data = rendition.value(forKey: "_srcData") as! Data
             let length = UInt(data.count)
@@ -198,13 +200,13 @@ enum AssetUtil {
     }
 
     private static func createRendition(from themeStore: NSObject, _ keyList: UnsafeMutableRawPointer)
-        -> NSObject
+        -> NSObject?
     {
         let renditionWithKeySelector = Selector(("renditionWithKey:"))
         let renditionWithKeyMethod = themeStore.method(for: renditionWithKeySelector)!
         let renditionWithKeyImp = unsafeBitCast(renditionWithKeyMethod, to: objectiveCMethodImp.self)
-        return renditionWithKeyImp(themeStore, renditionWithKeySelector, keyList)!.takeUnretainedValue()
-            as! NSObject
+        return renditionWithKeyImp(themeStore, renditionWithKeySelector, keyList)?.takeUnretainedValue()
+            as? NSObject
     }
 
     private static func handleReferenceKey(
@@ -222,7 +224,9 @@ enum AssetUtil {
             referenceKey.perform(Selector(("keyList"))),
             to: UnsafeMutableRawPointer.self
         )
-        let referenceRendition = createRendition(from: themeStore, referenceKeyList)
+        guard let referenceRendition = createRendition(from: themeStore, referenceKeyList) else {
+            return false
+        }
 
         if let result = referenceRendition.perform(Selector(("unslicedImage"))) {
             let image = result.takeUnretainedValue() as! CGImage

npm-binary-distributions/darwin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-darwin",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The darwin distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

npm-binary-distributions/linux-arm/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-linux-arm",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The linux arm distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

npm-binary-distributions/linux-arm64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-linux-arm64",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The linux arm64 distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

npm-binary-distributions/linux-i686/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-linux-i686",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The linux x86 and ia32 distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

npm-binary-distributions/linux-x64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-linux-x64",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The linux x64 distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

npm-binary-distributions/win32-arm64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-win32-arm64",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The windows arm64 distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

npm-binary-distributions/win32-i686/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-win32-i686",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The windows x86 and ia32 distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

npm-binary-distributions/win32-x64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli-win32-x64",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "The windows x64 distribution of the Sentry CLI binary.",
   "repository": "https://github.com/getsentry/sentry-cli",
   "license": "BSD-3-Clause",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cli",
-  "version": "2.53.0",
+  "version": "2.54.0",
   "description": "A command line utility to work with Sentry. https://docs.sentry.io/hosted/learn/cli/",
   "repository": "git://github.com/getsentry/sentry-cli.git",
   "homepage": "https://docs.sentry.io/hosted/learn/cli/",
@@ -32,14 +32,14 @@
     "typescript": "~5.8.3"
   },
   "optionalDependencies": {
-    "@sentry/cli-darwin": "2.53.0",
-    "@sentry/cli-linux-arm": "2.53.0",
-    "@sentry/cli-linux-arm64": "2.53.0",
-    "@sentry/cli-linux-i686": "2.53.0",
-    "@sentry/cli-linux-x64": "2.53.0",
-    "@sentry/cli-win32-i686": "2.53.0",
-    "@sentry/cli-win32-x64": "2.53.0",
-    "@sentry/cli-win32-arm64": "2.53.0"
+    "@sentry/cli-darwin": "2.54.0",
+    "@sentry/cli-linux-arm": "2.54.0",
+    "@sentry/cli-linux-arm64": "2.54.0",
+    "@sentry/cli-linux-i686": "2.54.0",
+    "@sentry/cli-linux-x64": "2.54.0",
+    "@sentry/cli-win32-i686": "2.54.0",
+    "@sentry/cli-win32-x64": "2.54.0",
+    "@sentry/cli-win32-arm64": "2.54.0"
   },
   "scripts": {
     "postinstall": "node ./scripts/install.js",

scripts/post-release.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+
+# This script is run by Craft after a release is created.
+# We currently use it to bump the platform-specific optional dependencies to their new versions
+# in the package-lock.json, immediately after a release is created. This is needed for CI to
+# pass after the release is created.c
+
+set -eux
+OLD_VERSION="${1}"
+NEW_VERSION="${2}"
+
+git checkout master
+
+# We need to update the package-lock.json to include the new version of the optional dependencies.
+npm install --package-lock-only --ignore-scripts
+
+git add package-lock.json
+
+# Only commit if there are changes
+git diff --staged --quiet || git commit -m "build(npm): 🤖 Bump optional dependencies to ${NEW_VERSION}"
+git pull --rebase
+git push

src/commands/build/upload.rs

@@ -325,7 +325,8 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
             }
         );
         for (path, reason) in errored_paths_and_reasons {
-            warn!("  - {} ({})", path.display(), reason);
+            warn!("  - {}", path.display());
+            warn!("    Error: {reason:#}");
         }
     }