Fix: symlinks in normalized upload #2744
Merged
+68
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
force-pushed
the
fixSymlinkNormalize
branch
from
8cc67cf to
685a879
Compare
noahsmartin
requested review from
a team and
szokeasaurusrex
as code owners
noahsmartin
force-pushed
the
fixSymlinkNormalize
branch
from
0d44887 to
b36d735
Compare
|
Thanks @szokeasaurusrex I updated the description a bit and added the linked issue (credit to @chromy for finding it) |
szokeasaurusrex
approved these changes
Sep 16, 2025
@noahsmartin FYI to properly link a linear issue, you need to put "Closes" in front of the issue number ("fixes" or "resolves" might also work). I already made the change on this issue. That way, the PR is linked from the Linear issue page, and the Linear issue gets auto-closed when you mere the PR 🙂 If you just put the link, it appears the issue does not get linked to the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes uploads have symlinks in them, we need to preserve the contents of the upload, otherwise the code signature breaks. Additionally, the app size would change if we changed the contents, making our size analysis invalid
Closes EME-266