Add default vcs head_repo_name and provider parsing for mobile-app subcommand #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
rbro112
commented
Aug 11, 2025
| "/api/0/projects/wat-org/wat-project/files/preprodartifacts/assemble/", | ||
| ) | ||
| .with_header_matcher("content-type", "application/json") | ||
| .with_matcher(r#"{"checksum":"18e40e6e932d0b622d631e887be454cc2003dbb5","chunks":["18e40e6e932d0b622d631e887be454cc2003dbb5"],"head_sha":"test_head_sha"}"#) |
There was a problem hiding this comment.
With additional params, we don't want a 1:1 body matcher anymore, so removing should make this not fail when making default value changes.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
loewenheim
approved these changes
Aug 12, 2025
szokeasaurusrex
approved these changes
Aug 12, 2025
rbro112
force-pushed
the
ryan/add_default_vcs_head_repo_name_and_provider_parsing_for_mobile-app_subcommand
branch
from
74c2281 to
d320c06
Compare
rbro112
deleted the
ryan/add_default_vcs_head_repo_name_and_provider_parsing_for_mobile-app_subcommand
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default values for
vcs_providerandhead_repo_namearguments if not provided by the user. Confirmed locally that setting the arguments carries them through, and not setting correctly seeds the values with expected.