retry on cloudflare timeout #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrawat1992
requested review from
a team and
szokeasaurusrex
as code owners
|
Hi @szokeasaurusrex, sentry-cli is integrated with a lot of SDKs and it is very cumbersome to patch them all. This PR solves those problems in one shot. |
manishrawat1992
force-pushed
the
manishrawat/retry_524
branch
from
ae8a811 to
812582a
Compare
|
Thanks for the PR @manishrawat1992 , people are currently out on vacation. I'll try to get a decision on whether to merge this PR - might take a bit. |
loewenheim
approved these changes
Aug 13, 2025
Swatinem
approved these changes
Aug 13, 2025
|
Hi @adinauer, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of the self hosted installations are hosted behind cloudflare. By default, cloudflare proxy_write_timeout is set at 30s. If this timeout is breached, Cloudflare responds with error with status code 524. Currently this is treated as non retriable error by sentry-cli.
https://developers.cloudflare.com/support/troubleshooting/http-status-codes/cloudflare-5xx-errors/error-524/
This PR ensures that sentry-cli retries on this timeout.