feat(mobile-app): Add new VCS params to mobile-app command

[rbro112]

Adds new VCS params as args to the mobile-app command and passes them to the API (pending getsentry/sentry#97332). Notably removes sha in favor of head_sha. Given this command is still unreleased and marked experimental, this would usually be a breaking change but I don't believe we need any backwards compatibility here.

We'll implement default value providing for most of these as well in follow ups, as I'd prefer to silo those implementations for easier review && testing.

[rbro112]

• feat(mobile-app): Add new VCS params to mobile-app command #2682 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[trevor-e]

API lgtm

[rbro112]

Will follow in future PRs for each of these individually.

[szokeasaurusrex]

I am okay with us doing this in future PRs; however, I would prefer not to commit the TODO comment, lest we ever forget to remove it. We should track the work in GitHub/Linear issues instead

Suggested change

// TODO: Implement default values

[szokeasaurusrex]

lgtm, besides a few minor suggestions to address prior to merge

[szokeasaurusrex]

As PR's can only have positive numbers, I would use an unsigned integer (u32) here, rather than a signed integer

Suggested change

	pub pr_number: Option<i32>,
	pub pr_number: Option<u32>,

[szokeasaurusrex]

I am okay with us doing this in future PRs; however, I would prefer not to commit the TODO comment, lest we ever forget to remove it. We should track the work in GitHub/Linear issues instead

Suggested change

// TODO: Implement default values

[szokeasaurusrex]

This way, Clap can parse straight to a u32 and perform the validation internally

Suggested change

	Arg::new("pr_number")
	.long("pr-number")
	.help("The pull request number to use for the upload. If not provided, the current pull request number will be used.")
	Arg::new("pr_number")
	.long("pr-number")
	.value_parser(clap::value_parser!(u32))
	.help("The pull request number to use for the upload. If not provided, the current pull request number will be used.")

[rbro112]

Very nice to know, figured there was a way to do this I was missing

[szokeasaurusrex]

Once you change the pr_number's type to u32 in the struct, and once you add the value_parser above, you will be able to simplify this line greatly:

Suggested change

	let pr_number = matches
	.get_one("pr_number")
	.map(String::as_str)
	.and_then(|s| s.parse::<i32>().ok());
	let pr_number = matches.get_one("pr_number");