build: Replace username with whoami
#2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
commented
Mar 21, 2025
There was a problem hiding this comment.
I tested this change manually to ensure whoami gets the correct username when using the sentry-cli send-event command. Example event here: https://sentry-sdks.sentry.io/issues/6438150058/events/a04c3b53975748abbaff4692a1bb977a/.
|
There are still some remaining transitive dependencies on |
loewenheim
approved these changes
Mar 21, 2025
Base automatically changed from
szokeasaurusrex/no-direct-winapi-dependency
to
master
March 21, 2025 14:29
`username` is completely unmaintained, and it depends on `winapi`, preventing us from supporting Windows on ARM. Use `whoami` instead to get the curent user. Ref #1426
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-username
branch
from
057ea74 to
28bb68b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usernameis completely unmaintained, and it depends onwinapi, preventing us from supporting Windows on ARM. Usewhoamiinstead to get the curent user.Ref #1426