-
-
Notifications
You must be signed in to change notification settings - Fork 235
build(macos): Sign macOS binaries #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e33d3ac
build(macos): Sign macOS binaries
szokeasaurusrex 300a844
try disabling universal binary
szokeasaurusrex b96161c
debug statements
szokeasaurusrex eac90d7
move to root directory
szokeasaurusrex 179d1c2
hopefully good now
szokeasaurusrex 0349b2f
try hardened runtime
szokeasaurusrex 2534fbf
remove quotes
szokeasaurusrex a5dd9de
--for-notarization
szokeasaurusrex 2d1f670
add entitlements
szokeasaurusrex 31d2cfa
checkout path
szokeasaurusrex 6e783c1
Use command arguments rather than toml
szokeasaurusrex b713c9b
try `./`
szokeasaurusrex 4fd4c80
use rcodesign directly
szokeasaurusrex be3e571
correct arg
szokeasaurusrex 71831b7
Update .github/workflows/build.yml
szokeasaurusrex 6734eef
add sha check and fix node&python builds
szokeasaurusrex a734716
fix typo, remove debug code
szokeasaurusrex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
|
||
<!-- Entitlements for macOS --> | ||
|
||
<plist version="1.0"> | ||
<dict> | ||
</dict> | ||
</plist> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think you need a check out as you're not using anything from the repo?I see that we use entitlements from the repo. Not sure how long this step takes but if it's longer than a few seconds we can upload entitlements file along with the artifacts and skip this step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it takes that long – the waiting for notarization I think takes quite a bit longer